-
Notifications
You must be signed in to change notification settings - Fork 4k
feat: [firebase_ui_auth] [firebase_ui_oauth] Allow for custom labels to be used for custom OAuth providers #9858
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Seems like there are analysis issues in other packages unrelated to this PR. Probably not within the scope of this PR to fix them. |
@Rexios80 out of curiosity: what provider did you implement? Is this an officially supported provider that is available on firebase console? |
Do you want to own that package? Or is it too custom to be in this repo? I was going to publish it myself if you don't see an issue with it. |
@Rexios80 feel free to publish |
Description
I made a custom OAuth provider so that I could add it to the sign in page. The issue is that the existing code expects there to only ever be the providers that exist in this repo. This was causing a crash when fetching the OAuth button label text.
Checklist
Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes (
[x]
).This will ensure a smooth and quick review process. Updating the
pubspec.yaml
and changelogs is not required.///
).melos run analyze
) does not report any problems on my PR.Breaking Change
Does your PR require plugin users to manually update their apps to accommodate your change?