-
Notifications
You must be signed in to change notification settings - Fork 1.3k
Allow a list of strings as header value in JWT::encode()
#595
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
I don't have a google account associated with my email and don't want to create one. I'm ok with the CLA though. anyway, anybody feel free to take over this fix if possible. I also don't care if this is copied from me without mentioning me (e.g. @hultberg).. that's how you make things hard in OSS with weird processes 😓 |
@herndlm unfortunately that isn't my call wrt the CLA But I'm confused what you're trying to accomplish with this PR. You're only changing the PHP doc, which already accepts an array. Edit: I think I understand... maybe make the php typehint |
yeah, |
feel free to create a new PR instead please and also feel free to use thx! |
That's good to know! I like the strictness but IMHO the other is much more readable when not using a static analyzer.
Will do. Thanks for your contribution! |
Fixes #593
In our case we need to be able to set the
crit
claim for a third party webservice. Found more info about crit here: https://mojoauth.com/glossary/jwt-critical/