Migrate all quickstart apps to most recent AGP and kts syntax #1493
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marinacoelho
commented
May 10, 2023
perf/app/build.gradle.kts
Outdated
| proguardFiles(getDefaultProguardFile("proguard-android.txt"), "proguard-rules.pro") | ||
| } | ||
| getByName("debug") { | ||
| //FirebasePerformance { |
There was a problem hiding this comment.
@thatfiredev Do you know how to migrate this to kts? I've tried absolutely everything and can't make it work :(
There was a problem hiding this comment.
I think you might need to import com.google.firebase.perf.plugin.FirebasePerformance at the top of the file
thatfiredev
reviewed
May 11, 2023
auth/app/src/main/java/com/google/firebase/quickstart/auth/java/PasswordlessActivity.java
Show resolved
Hide resolved
…mc/update-agp-kts � Conflicts: � build.gradle
thatfiredev
approved these changes
May 16, 2023
thatfiredev
reviewed
May 16, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.