Skip to content

Replace var with let #46

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 7, 2019
Merged

Replace var with let #46

merged 1 commit into from
Jun 7, 2019

Conversation

IvanBila
Copy link
Contributor

@IvanBila IvanBila commented Jun 7, 2019

Summary

I've noticed that var is currently used in some parts of the firestore documentation over of let or const.
Using var is highly discouraged because:

  1. No error is thrown if you declare the same variable twice using var;
  2. Variables declared with var are not block-scoped(except some cases if they are in functions), they might even cause variable name collision.

On the other hand const and let allow block scoping and immutable variables(via reassignment).

@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here (e.g. I signed it!) and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

@samtstern
Copy link
Contributor

@IvanBila thanks! Will merge once the CLA is worked out.

@IvanBila
Copy link
Contributor Author

IvanBila commented Jun 7, 2019

@samtstern I've Signed the CLA

@googlebot
Copy link

CLAs look good, thanks!

ℹ️ Googlers: Go here for more info.

@samtstern samtstern merged commit 9ae3a00 into firebase:master Jun 7, 2019
@samtstern
Copy link
Contributor

Thank you @IvanBila for the contributioN!

@IvanBila IvanBila deleted the refactor/replace-var-with-let branch June 7, 2019 22:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants