Support projectId for cloud functions #85
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I was following https://firebase.google.com/docs/firestore/solutions/schedule-export in order to export my firestore database, and I noticed that my projectId was undefined (resulting in
TypeError: Cannot read property 'charCodeAt' of undefined
fromgoogle-gax
).Don't know exactly when GCP_PROJECT is populated, but with this fix GCLOUD_PROJECT will be picked up for the cloud functions 🏄♂️