-
Notifications
You must be signed in to change notification settings - Fork 149
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use p-map instead of promise-pool #946
Conversation
@firecow can you give a minimal example to check the issue against? |
Good idea, we don't want this to come back 👍 |
@naweiss I've added a test to prevent regression 👍 |
… parser to be completely finished
This pull request sets up GitHub code scanning for this repository. Once the scans have completed and the checks have passed, the analysis results for this pull request branch will appear on this overview. Once you merge this pull request, the 'Security' tab will show more code scanning analysis results (for example, for the default branch). Depending on your configuration and choice of analysis tool, future pull requests will be annotated with code scanning analysis results. For more information about GitHub code scanning, check out the documentation. |
Kudos, SonarCloud Quality Gate passed! |
@naweiss Have a look. See #943 for more information.
promise-pool package doesn't throw on promise rejections, and we want that to happen, so developers can see error messages.