Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use p-map instead of promise-pool #946

Merged
merged 11 commits into from
Aug 2, 2023
Merged

Conversation

firecow
Copy link
Owner

@firecow firecow commented Jul 30, 2023

@naweiss Have a look. See #943 for more information.

promise-pool package doesn't throw on promise rejections, and we want that to happen, so developers can see error messages.

@firecow firecow requested a review from naweiss July 30, 2023 12:31
@naweiss
Copy link
Collaborator

naweiss commented Jul 30, 2023

@firecow can you give a minimal example to check the issue against?

@firecow
Copy link
Owner Author

firecow commented Jul 30, 2023

@firecow can you give a minimal example to check the issue against?

Good idea, we don't want this to come back 👍

@firecow
Copy link
Owner Author

firecow commented Jul 30, 2023

@naweiss I've added a test to prevent regression 👍

@github-advanced-security
Copy link

This pull request sets up GitHub code scanning for this repository. Once the scans have completed and the checks have passed, the analysis results for this pull request branch will appear on this overview. Once you merge this pull request, the 'Security' tab will show more code scanning analysis results (for example, for the default branch). Depending on your configuration and choice of analysis tool, future pull requests will be annotated with code scanning analysis results. For more information about GitHub code scanning, check out the documentation.

@sonarqubecloud
Copy link

sonarqubecloud bot commented Aug 2, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 1 Code Smell

89.3% 89.3% Coverage
0.0% 0.0% Duplication

@firecow firecow merged commit 247ad58 into master Aug 2, 2023
@firecow firecow deleted the bug-fix-promise-error-handling branch August 2, 2023 21:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants