Skip to content

Move autogenerated code in folders with _gen suffix #602

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
andreeaflorescu opened this issue Nov 19, 2018 · 1 comment
Closed

Move autogenerated code in folders with _gen suffix #602

andreeaflorescu opened this issue Nov 19, 2018 · 1 comment
Labels
Good first issue Indicates a good issue for first-time contributors Priority: Low Indicates that an issue or pull request should be resolved behind issues or pull requests labelled `

Comments

@andreeaflorescu
Copy link
Member

The crates with _sys contain auto-generated code. Move the code to directories that end with _gen suffix so it is clear that the code is auto-generated.

When we rename the directories, we should also update the integration test test_coverage from tests/integration_tests/build/test_coverage.py. In this test we are excluding the auto-generated code from the coverage report.
@andreeaflorescu andreeaflorescu added Good first issue Indicates a good issue for first-time contributors refactoring labels Nov 19, 2018
@andreeaflorescu andreeaflorescu mentioned this issue Nov 19, 2018
Closed
@andreeaflorescu andreeaflorescu added the Priority: Low Indicates that an issue or pull request should be resolved behind issues or pull requests labelled ` label Nov 22, 2018
@sejr sejr mentioned this issue Nov 27, 2018
Merged
@sejr
Copy link

sejr commented Dec 5, 2018

#676 merged—this issue can be closed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Good first issue Indicates a good issue for first-time contributors Priority: Low Indicates that an issue or pull request should be resolved behind issues or pull requests labelled `
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@sejr @andreeaflorescu @raduweiss