pretty print panics #854
Merged
pretty print panics #854
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Instead of printing the PanicInfo using debug, we can use display
as this generates a human readable panic.
Before:
Panic occurred: PanicInfo { payload: Any, message: Some(Failed to
open the API socket: IO Error: Io(Os ...
After:
Firecracker panicked at 'Failed to open the API socket: IO Error:
...
This is the first step in having human readable panics. Next we
should implement Display for errors that can generate panics.
Signed-off-by: Andreea Florescu <[email protected]>
andreeaflorescu
force-pushed
the
display_panic_info
branch
from
64d15bd to
39d9e25
Compare
alxiord
approved these changes
Jan 16, 2019
dianpopa
approved these changes
Jan 16, 2019
acatangiu
approved these changes
Jan 16, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available: #837
Description of changes:
Instead of printing the PanicInfo using debug, we can use display
as this generates a human readable panic.
Before:
Panic occurred: PanicInfo { payload: Any, message: Some(Failed to
open the API socket: IO Error: Io(Os ...
After:
Firecracker panicked at 'Failed to open the API socket: IO Error:
...
This is the first step in having human readable panics. Next we
should implement Display for errors that can generate panics.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.