Skip to content

Combining RowSet and chunks sometimes there are rowsets as well as chunks #27

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 6, 2022

Conversation

PeterDRasmussen
Copy link
Contributor

I found a weird issue today as not all the rows I selected from snowflake was returned. When I ran the query directly in the snowflake worksheet everything was fine. It seemed like it was missing half a chunk or so. I was able to reproduce the error as seen below from a debug session:

Snowflake-client-rowset-issue

It seems that sometimes not all the data is contained within the chunks, some rows are returned by the initial response as part of RowSet. To get all the rows I had to combine the data from the chunks along with the data inside RowSet (see the blue dots). My region "eu-north-1" was also missing in GetCloudTagByRegion and I could not get the integration tests to run without adding a warehouse in IntegrationTestBase.

Note: It seems that on subsequent requests all the rows are within chunks, but you can try and change the selectCount in the tests to provoke it.

Let me know what you think!

@PeterDRasmussen
Copy link
Contributor Author

PeterDRasmussen commented Oct 3, 2022

Oh and it is likely related to "Chunk going missing #24"

@PeterDRasmussen
Copy link
Contributor Author

@fixer-m is there any chance you can look at this in the near future? I think this bug makes the client difficult to use.

@fixer-m fixer-m merged commit bbb7f43 into fixer-m:master Oct 6, 2022
@fixer-m
Copy link
Owner

fixer-m commented Oct 6, 2022

@PeterDRasmussen Wow, this is really good catch - thank you! Never thought that it could return rows in chunks AND in a rowset at the same time. I'm gonna merge this fix and release new package version soon.

@PeterDRasmussen
Copy link
Contributor Author

@fixer-m I find it super odd as well, Thank you!

@PeterDRasmussen
Copy link
Contributor Author

@fixer-m Do you know when you will have time to publish a new version? As mentioned, I also think this fixes the open issue #24

@fixer-m
Copy link
Owner

fixer-m commented Oct 10, 2022

@PeterDRasmussen I have just pushed new package version to NuGet. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants