Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bugfix: FusedAddRMSNorm kernels might require more than 48KB shared memory when d is large. #718

Merged
merged 2 commits into from
Jan 6, 2025
Merged

bugfix: FusedAddRMSNorm kernels might require more than 48KB shared memory when d is large. #718

merged 2 commits into from
Jan 6, 2025

Conversation

bobboli
Copy link
Contributor

@bobboli bobboli commented Jan 6, 2025

The original implementation will cause RuntimeError: invalid argument when hidden_size=16384.

yzh119
yzh119 approved these changes Jan 6, 2025
View reviewed changes
Copy link
Collaborator

@yzh119 yzh119 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch, thank you!

@yzh119 yzh119 merged commit 9a00cc2 into flashinfer-ai:main Jan 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yzh119 yzh119 yzh119 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bobboli @yzh119