perf: refactor fa2 prefill template #776
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yzh119
changed the title
abcdabcd987
added a commit
to abcdabcd987/flashinfer
that referenced
this pull request
Feb 4, 2025
This reverts commit fc03772.
yzh119
pushed a commit
that referenced
this pull request
Feb 4, 2025
#776 added CTA_TILE_Q=32 but it produces incorrect result.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR refactors the FA2-based prefill template, including the following changes:
CTA_TILE_Q=32.We also tried
CTA_TILE_Q=8, the half-mma optimization for GQA decoding with low group ratio (<=8), however, the performance improvement is very marginal (<1%) and make codebase complicated and thus we didn't incorporate this feature in the PR.