New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

misc: Remove duplicate param set in MLA kernel #850

Merged

zhyncs merged 1 commit into main from mla-duplicate-param-set

Feb 16, 2025

Collaborator

MasterJH5574 commented Feb 16, 2025

This PR removes the duplicate set of params.kv_indices in the MLA kernel.


          misc: Remove duplicate param set in MLA kernel

08196d3

This PR removes the duplicate set of `params.kv_indices` in the MLA kernel.

Collaborator Author

MasterJH5574 commented Feb 16, 2025 •

edited

Loading

Duplicate in a few lines below:

flashinfer/csrc/batch_mla_run.cu

Lines 71 to 75 in a695e95

    
           params.kv_indices = static_cast<IdType*>(kv_indices.data_ptr()); 
        
           params.q_indptr = GetPtrFromBaseOffset<IdType>(int_buffer_ptr, plan_info.q_indptr_offset); 
        
           params.kv_indptr = GetPtrFromBaseOffset<IdType>(int_buffer_ptr, plan_info.kv_indptr_offset); 
        
           params.kv_indices = static_cast<IdType*>(kv_indices.data_ptr());

zhyncs approved these changes

View reviewed changes

zhyncs merged commit 55b75d8 into main

zhyncs deleted the mla-duplicate-param-set branch

February 16, 2025 07:22

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet