Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

perf: use max probability instead of 1 as upper bound in top-p/k sampling #925

Merged
merged 1 commit into from
Mar 9, 2025
Merged

perf: use max probability instead of 1 as upper bound in top-p/k sampling #925

merged 1 commit into from
Mar 9, 2025

Conversation

yzh119
Copy link
Collaborator

@yzh119 yzh119 commented Mar 9, 2025

Reduce maximum number of iterations.

@yzh119 yzh119 requested a review from Copilot March 9, 2025 22:10
Copilot
Copilot AI reviewed Mar 9, 2025
View reviewed changes
Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 1 out of 1 changed files in this pull request and generated no comments.

@yzh119 yzh119 requested a review from Copilot March 9, 2025 22:12
Copilot
Copilot AI reviewed Mar 9, 2025
View reviewed changes
Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 1 out of 1 changed files in this pull request and generated no comments.

@yzh119 yzh119 merged commit e3853dd into main Mar 9, 2025
@MasterJH5574 MasterJH5574 deleted the reduce-upper-bound-sampling branch March 13, 2025 14:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

Copilot code review Copilot Copilot left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@yzh119