Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bugfix: Fix missing PyModuleDef field initializers #946

Merged
merged 1 commit into from
Mar 17, 2025

Conversation

sampan26
Copy link
Contributor

Complete the PyModuleDef structure initialization in pytorch_extension_utils.h by adding NULL initializers for m_slots, m_traverse, m_clear, and m_free fields.
This resolves compiler errors when using -Werror=missing-field-initializers.

Copy link
Collaborator

@yzh119 yzh119 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for the fix!

@yzh119 yzh119 changed the title Fix missing PyModuleDef field initializers bugfix: Fix missing PyModuleDef field initializers Mar 17, 2025
@yzh119 yzh119 merged commit 6d5320b into flashinfer-ai:main Mar 17, 2025
2 checks passed
yyihuang pushed a commit to yyihuang/flashinfer that referenced this pull request Mar 17, 2025
Complete the PyModuleDef structure initialization in
pytorch_extension_utils.h by adding NULL initializers for m_slots,
m_traverse, m_clear, and m_free fields.
This resolves compiler errors when using
-Werror=missing-field-initializers.
yyihuang pushed a commit to yyihuang/flashinfer that referenced this pull request Mar 17, 2025
Complete the PyModuleDef structure initialization in
pytorch_extension_utils.h by adding NULL initializers for m_slots,
m_traverse, m_clear, and m_free fields.
This resolves compiler errors when using
-Werror=missing-field-initializers.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants