[CHORE] Rename output_emitted_token_num -> output_emitted_draft_token_num
#977
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yzh119
reviewed
Mar 29, 2025
There was a problem hiding this comment.
LGTM overall, can you use pre-commit to format your code?
Some of the format checks failed: https://github.com/flashinfer-ai/flashinfer/actions/runs/14140711551/job/39622375707?pr=977
Thank you for your contribution!
jon-chuang
force-pushed
the
jon-chuang/rename
branch
from
c666423 to
50516a5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With the old naming, it is easy to get confused with off by one error, with the new naming it is clear.
See example special handling required here due to unclear API: https://github.com/vllm-project/vllm/blob/280d074103160d042059dc60c28898fd9fb56568/vllm/model_executor/layers/rejection_sampler.py#L139