Skip to content

DO NOT MERGE - test build #76

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from
Closed

Conversation

jliljebl
Copy link
Collaborator

DO NOT MERGE THIS PATCH

This is a test build to diagnose a failing launch issue after successful build on developer system.

DO NOT MERGE THIS PATCH

@flathubbot
Copy link
Contributor

🚧 Test build enqueued.

@flathubbot
Copy link
Contributor

🚧 Started test build.

@flathubbot
Copy link
Contributor

🚧 Test build failed.

@flathubbot
Copy link
Contributor

🚧 Test build enqueued.

@flathubbot
Copy link
Contributor

🚧 Started test build.

@flathubbot
Copy link
Contributor

🚧 Test build succeeded. To test this build, install it from the testing repository:

flatpak install --user https://dl.flathub.org/build-repo/180572/io.github.jliljebl.Flowblade.flatpakref

@jliljebl jliljebl closed this Apr 25, 2025
@jliljebl
Copy link
Collaborator Author

This fails to launch.

@hfiguiere hfiguiere reopened this Apr 25, 2025
@flathubbot
Copy link
Contributor

🚧 Test build enqueued.

@flathubbot
Copy link
Contributor

🚧 Started test build.

@hfiguiere
Copy link
Contributor

hfiguiere commented Apr 25, 2025

Not sure what's happening exactly but the hashbang (interpreter script) in the python script is #!python

The manual says The interpreter must be a valid pathname for an executable file. which this is not.
If I do python flowblade it works, as it bypass the interpreter script.

Looking at code https://github.com/jliljebl/flowblade/blob/master/flowblade-trunk/flowblade#L1 , the original source is correct ; so it got changed somewhere, during the "setup". Did Python 3.12 introduce the issue?

@hfiguiere
Copy link
Contributor

The currently available version has #!/usr/bin/python3 as expected.

@jliljebl
Copy link
Collaborator Author

Did Python 3.12 introduce the issue?

I think so.

@jliljebl
Copy link
Collaborator Author

I just manually changed #!python to #!/usr/bin/python3 in the test flatpak install I got with:

flatpak install --user https://dl.flathub.org/build-repo/180572/io.github.jliljebl.Flowblade.flatpakref

and now it launches. Now we know what causes not launching issue, but not why we get the change to #!python.

@flathubbot
Copy link
Contributor

🚧 Test build succeeded. To test this build, install it from the testing repository:

flatpak install --user https://dl.flathub.org/build-repo/180611/io.github.jliljebl.Flowblade.flatpakref

- ./vendored-meson/meson/meson.py setup builddir --buildtype=debugoptimized
--prefix=${FLATPAK_DEST}
- cd builddir && ninja
- cd builddir && ninja install
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm wondering why this is not buildsystem: meson

@jliljebl
Copy link
Collaborator Author

jliljebl commented Apr 25, 2025

I'm wondering why this is not buildsystem: meson

I just went out looking for build recipe for numpy build without setup.py, found this and copy pasted.

@jliljebl
Copy link
Collaborator Author

This still does not launch. What do you think, should I try to just add a line to .yaml that overwrites first line of launch script or is there some more 'correct' solution?

@jliljebl
Copy link
Collaborator Author

jliljebl commented Apr 25, 2025

I found this issue pypa/setuptools#4863 with title build_editable does not emit #!python shebang for scripts #4863

So it is setuptools that is doing this. I will need to look at how fix this as there quite many ways of moving forward from here. I'm closing the PR because pressing Merge pull request would kill all Flowblade Flathub installs everywhere and it is making me nervous. I'll open another one when I have the fix.

@jliljebl jliljebl closed this Apr 25, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants