-
Notifications
You must be signed in to change notification settings - Fork 3
DO NOT MERGE - test build #76
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
🚧 Test build enqueued. |
🚧 Started test build. |
🚧 Test build failed. |
🚧 Test build enqueued. |
🚧 Started test build. |
🚧 Test build succeeded. To test this build, install it from the testing repository:
|
This fails to launch. |
🚧 Test build enqueued. |
🚧 Started test build. |
Not sure what's happening exactly but the hashbang (interpreter script) in the python script is The manual says Looking at code https://github.com/jliljebl/flowblade/blob/master/flowblade-trunk/flowblade#L1 , the original source is correct ; so it got changed somewhere, during the "setup". Did Python 3.12 introduce the issue? |
The currently available version has |
I think so. |
I just manually changed #!python to #!/usr/bin/python3 in the test flatpak install I got with:
and now it launches. Now we know what causes not launching issue, but not why we get the change to #!python. |
🚧 Test build succeeded. To test this build, install it from the testing repository:
|
- ./vendored-meson/meson/meson.py setup builddir --buildtype=debugoptimized | ||
--prefix=${FLATPAK_DEST} | ||
- cd builddir && ninja | ||
- cd builddir && ninja install |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm wondering why this is not buildsystem: meson
I just went out looking for build recipe for numpy build without setup.py, found this and copy pasted. |
This still does not launch. What do you think, should I try to just add a line to .yaml that overwrites first line of launch script or is there some more 'correct' solution? |
I found this issue pypa/setuptools#4863 with title build_editable does not emit #!python shebang for scripts #4863 So it is setuptools that is doing this. I will need to look at how fix this as there quite many ways of moving forward from here. I'm closing the PR because pressing Merge pull request would kill all Flowblade Flathub installs everywhere and it is making me nervous. I'll open another one when I have the fix. |
DO NOT MERGE THIS PATCH
This is a test build to diagnose a failing launch issue after successful build on developer system.
DO NOT MERGE THIS PATCH