-
Notifications
You must be signed in to change notification settings - Fork 57
ABC boundary #2424
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: develop
Are you sure you want to change the base?
ABC boundary #2424
Conversation
could you drop the "revert ..." commit to have a cleaner PR? |
826ee5f
to
0ae4d61
Compare
ah, yeah, forgot about that |
6e9acad
to
060fad4
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me! A couple suggestions to improve descriptions. Also is there a simple reference you could add that describes the BC? like Taflove?
060fad4
to
cc75b13
Compare
Code Coverage Summary
Diff against develop
Results for commit: cc75b13 Minimum allowed coverage is ♻️ This comment has been updated with latest results |
Changed Files Coverage
Results for commit: cc75b13 Minimum allowed coverage is ♻️ This comment has been updated with latest results |
See https://github.com/flexcompute/compute/pull/1445 for description/discussion