修复可能的 context 泄露以及遗漏的错误处理 #1965
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
结构体的 tag 字段的多个 key-value 对需要使用空格分隔，否则会有以下警告： struct field tag `json:"attachments" form:"attachments" gorm:"column:attachments;comment:相关附件;"swaggertype:"array,object"` not compatible with reflect.StructTag.Get: key:"value" pairs not separated by spaces
不处理 cancel 相关返回函数，会造成 context 一直停留在 background. the cancel function returned by context.WithTimeout should be called, not discarded, to avoid a context leak
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
.gitignore: 忽略 Windows 下编译的二进制文件和 SQLite 数据文件UpdateCasbinApi方法遗漏的错误处理