Skip to content
This repository was archived by the owner on Dec 5, 2024. It is now read-only.

React 18 support #440

Merged
merged 7 commits into from
Apr 23, 2022
Merged

React 18 support #440

merged 7 commits into from
Apr 23, 2022

Conversation

atomiks
Copy link
Collaborator

@atomiks atomiks commented Apr 13, 2022

Closes #349

@layershifter
Copy link

@atomiks friendly ping, any estimates when this could be released?

package.json Outdated
"react": "17.0.0",
"react-dom": "^17.0.0",
"react": "18.0.0",
"react-dom": "^18.0.0",
"react-spring": "^8.0.27",
"react-test-renderer": "^17.0.0",
Copy link

@chentsulin chentsulin Apr 22, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should react-test-renderer be updated to 18 too?

@ErrorEater
Copy link

When will React 18 be supported?
Upgraded and stuck.

@FezVrasta
Copy link
Member

I need to find some time to make this PR pass the tests, if anyone wants to contribute please do so 🙇 otherwise I'll try to do it as soon I have some time available

@chentsulin
Copy link

chentsulin commented Apr 23, 2022

Hi @FezVrasta, I created #441 and made some changes to fix the tests there.

@FezVrasta FezVrasta merged commit e36e168 into master Apr 23, 2022
@atomiks atomiks deleted the react-18 branch April 23, 2022 06:58
@chentsulin
Copy link

@FezVrasta How about releasing a new minor version based on this PR?

@FezVrasta FezVrasta mentioned this pull request Apr 25, 2022
@FezVrasta
Copy link
Member

Waiting to understand if we also need #439

@ErrorEater
Copy link

Waiting to understand if we also need #439

Ready to release? We're stuck.

@atomiks
Copy link
Collaborator Author

atomiks commented Apr 27, 2022

#439 is not relevant for now, just release @FezVrasta

@FezVrasta
Copy link
Member

2.3.0 is now live with these changes

@varand-pez
Copy link

I'm using Semantic UI React and found a thread about this issue in that repo which led me here. Just wanted to say this is still happening. I'm using
semantic-ui 2.13 which uses react-poper 2.3.0 and react 18.2.0

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Single frame positioning glitch in concurrent mode
6 participants