Prevent possible race condition in NotifyAppControl #54
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
AppControlManager
is not thread-safe and may cause the following exception (reported by a third-party developer) when the UI thread (Dart code) is notified of an app control event (byNotifyAppControl
) and tries to access the associated app control instance throughNativeAttachAppControl
before the instance is added toAppControlManager
on the platform thread.I'm not sure if this will fix the error. Let me just give it a try.