Skip to content

Show more symbols on profiling builds #104

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Jun 14, 2021
Merged

Show more symbols on profiling builds #104

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
b9b44b9
Show more symbols on profiling builds
pwasowski2 Jun 2, 2021
21cd4bd
Remove libdart dependency
pwasowski2 Jun 9, 2021
24ab7ab
Add libdart dependency for builds with enabled profiling
pwasowski2 Jun 9, 2021
d5b2077
Fix shell/platform/tizen/BUILD.gn formatting
pwasowski2 Jun 9, 2021
01d926a
Remove dependency on libdart
pwasowski2 Jun 11, 2021
23ea830
Remove unnecessary import
pwasowski2 Jun 11, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions shell/platform/tizen/BUILD.gn
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -161,6 +161,7 @@ template("embedder_for_profile") {
public_deps = [ ":flutter_engine" ]

deps = [
"//flutter/runtime:libdart",
"//flutter/shell/platform/common/cpp:common_cpp",
"//flutter/shell/platform/common/cpp:common_cpp_input",
"//flutter/shell/platform/common/cpp:common_cpp_library_headers",
Expand Down
2 changes: 1 addition & 1 deletion tools/gn
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -282,7 +282,7 @@ def to_gn_args(args):

# We should not need a special case for x86, but this seems to introduce text relocations
# even with -fPIC everywhere.
# gn_args['enable_profiling'] = args.runtime_mode != 'release' and args.android_cpu != 'x86'
gn_args['enable_profiling'] = args.runtime_mode != 'release' and args.android_cpu != 'x86'

if args.arm_float_abi:
gn_args['arm_float_abi'] = args.arm_float_abi
Expand Down