Add flutter_tizen_texture_registrar unittest #141
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@WonyoungChoi I habitually amend the contents of review. 😢 |
bbrto21
reviewed
Jul 13, 2021
swift-kim
reviewed
Jul 13, 2021
Signed-off-by: MuHong Byun <[email protected]>
* Remove redundant code Signed-off-by: MuHong Byun <[email protected]>
swift-kim
reviewed
Jul 14, 2021
| } | ||
|
|
||
| bool ExternalTexturePixelGL::CopyPixelBuffer(size_t& width, size_t& height) { | ||
| if (texture_callback_ && user_data_) { |
There was a problem hiding this comment.
user_data_ could be null I think.
There was a problem hiding this comment.
Yes, you're right!
To be honest, this is a trick to avoid build errors. 😢
I guess this TC tests the functionality of the |
|
Oh, if that's the case, I got it. |
Signed-off-by: MuHong Byun <[email protected]>
bbrto21
approved these changes
Jul 14, 2021
swift-kim
pushed a commit
that referenced
this pull request
Sep 27, 2021
* Add flutter_tizen_texture_registrar unittest Signed-off-by: MuHong Byun <[email protected]> * Apply review's comment * Remove redundant code Signed-off-by: MuHong Byun <[email protected]> * Apply review's comment #2 Signed-off-by: MuHong Byun <[email protected]>
swift-kim
pushed a commit
that referenced
this pull request
Nov 14, 2021
* Add flutter_tizen_texture_registrar unittest Signed-off-by: MuHong Byun <[email protected]> * Apply review's comment * Remove redundant code Signed-off-by: MuHong Byun <[email protected]> * Apply review's comment #2 Signed-off-by: MuHong Byun <[email protected]>
swift-kim
pushed a commit
that referenced
this pull request
Dec 9, 2021
* Add flutter_tizen_texture_registrar unittest Signed-off-by: MuHong Byun <[email protected]> * Apply review's comment * Remove redundant code Signed-off-by: MuHong Byun <[email protected]> * Apply review's comment #2 Signed-off-by: MuHong Byun <[email protected]>
swift-kim
pushed a commit
that referenced
this pull request
Dec 17, 2021
* Add flutter_tizen_texture_registrar unittest * Apply review's comment Signed-off-by: MuHong Byun <[email protected]>
swift-kim
pushed a commit
that referenced
this pull request
Feb 7, 2022
* Add flutter_tizen_texture_registrar unittest * Apply review's comment Signed-off-by: MuHong Byun <[email protected]>
swift-kim
pushed a commit
that referenced
this pull request
Feb 11, 2022
* Add flutter_tizen_texture_registrar unittest * Apply review's comment Signed-off-by: MuHong Byun <[email protected]>
swift-kim
pushed a commit
that referenced
this pull request
May 12, 2022
* Add flutter_tizen_texture_registrar unittest * Apply review's comment Signed-off-by: MuHong Byun <[email protected]>
swift-kim
pushed a commit
that referenced
this pull request
Aug 5, 2022
Signed-off-by: MuHong Byun <[email protected]>
swift-kim
pushed a commit
that referenced
this pull request
Sep 1, 2022
…ackend. (#141) As we add more rendering backends, adding a new enum value to a single macro `INSTANTIATE_PLAYGROUND_SUITE` in `playground.h` will create a new test variant in any suite that uses playgrounds. The invocations will look like the following: ``` [ RUN ] Play/TypographerTest.CanCreateGlyphAtlas/Metal [ OK ] Play/TypographerTest.CanCreateGlyphAtlas/Metal (210 ms) [ RUN ] Play/TypographerTest.CanCreateGlyphAtlas/OpenGLES [ OK ] Play/TypographerTest.CanCreateGlyphAtlas/OpenGLES (xxx ms) ``` If you want to test just one backend, you may add a filter like so `--gtest_filter="*/Metal"` Right now, I have not added a the OpenGLES variant to the default test suite instantiation since there are so many failures (that is just a stub ATM). But, if the need arises to skip specific tests based on the backend in use (we won't support instancing in OpenGLES for example), the backend for the playground may be queried before deciding to GTEST_SKIP the invocation. One additional change in the patch that will be reworked soon is the Metal specificity of the source set generated after reflection. This will be made agnostic in the coming few patches. Right now, these headers are in the `mtl` folder.
swift-kim
pushed a commit
that referenced
this pull request
Sep 1, 2022
Signed-off-by: MuHong Byun <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Contains follow things: