-
Notifications
You must be signed in to change notification settings - Fork 17
Refactor the logger #144
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor the logger #144
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I like old style(printf-like) better.. but It looks like much more trendy code! 😄
@bwikbs I also find the printf-style logs are more readable and easy to format in some cases, but the stream style has some benefits as explained in the Google style guide.
I guess the portability here means the need to use format specifiers like |
@swift-kim 👍 I can't say a word.. |
@bbrto21 I changed the log level of some messages in |
- Replace __FILE__ with __MODULE__. - Resolve unused variable warning: kLogTag. - Typo fix and etc.
* Rewrite tizen_log in the C++ style * Convert logs to streams * Rename tizen_log to logger * Misc fixes - Replace __FILE__ with __MODULE__. - Resolve unused variable warning: kLogTag. - Typo fix and etc. * Change min logging level to Debug when --verbose-logging is set * Resolve conflicts & additional clean-up * Resolve conflicts again
* Rewrite tizen_log in the C++ style * Convert logs to streams * Rename tizen_log to logger * Misc fixes - Replace __FILE__ with __MODULE__. - Resolve unused variable warning: kLogTag. - Typo fix and etc. * Change min logging level to Debug when --verbose-logging is set * Resolve conflicts & additional clean-up * Resolve conflicts again
* Rewrite tizen_log in the C++ style * Convert logs to streams * Rename tizen_log to logger * Misc fixes - Replace __FILE__ with __MODULE__. - Resolve unused variable warning: kLogTag. - Typo fix and etc. * Change min logging level to Debug when --verbose-logging is set * Resolve conflicts & additional clean-up * Resolve conflicts again
* Rewrite tizen_log in the C++ style * Convert logs to streams * Rename tizen_log to logger * Change min logging level to Debug when --verbose-logging is set * Resolve conflicts & additional clean-up
* Rewrite tizen_log in the C++ style * Convert logs to streams * Rename tizen_log to logger * Change min logging level to Debug when --verbose-logging is set * Resolve conflicts & additional clean-up
* Rewrite tizen_log in the C++ style * Convert logs to streams * Rename tizen_log to logger * Change min logging level to Debug when --verbose-logging is set * Resolve conflicts & additional clean-up
* Rewrite tizen_log in the C++ style * Convert logs to streams * Rename tizen_log to logger * Change min logging level to Debug when --verbose-logging is set * Resolve conflicts & additional clean-up
* Rewrite tizen_log in the C++ style * Convert logs to streams * Rename tizen_log to logger * Change min logging level to Debug when --verbose-logging is set * Resolve conflicts & additional clean-up
* Rewrite tizen_log in the C++ style * Convert logs to streams * Rename tizen_log to logger * Change min logging level to Debug when --verbose-logging is set * Resolve conflicts & additional clean-up
Logger
,LogMessage
.FT_LOGE
→FT_LOG(Error)
.FT_RELEASE_ASSERT
,FT_COMPILE_ASSERT
).tizen_log.cc
andtizen_log_stub.cc
into one file.tizen_log.h
tologger.h
.--verbose-system-logs
option by fixing typo in the arg name (verbose-logging
→--verbose-logging
).Sorry for another large commit. The change couldn't be divided into smaller commits.