Skip to content

Clean up tizen/BUILD.gn #150

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jul 23, 2021
Merged

Clean up tizen/BUILD.gn #150

merged 3 commits into from
Jul 23, 2021

Conversation

swift-kim
Copy link
Member

  • Do not depend on the build option --disable-desktop-embeddings. Use embedder_for_target to determine the target instead.
  • Merge embedder_for_profile and embedder_executable into a single template (embedder).
  • Be more explicit. e.g. The use_evas_gl_renderer argument is always required.

bwikbs
bwikbs reviewed Jul 21, 2021
View reviewed changes
azure-pipelines.yml
@@ -68,13 +68,13 @@ jobs:
flutter/tools/gn \
--target-os linux \
--linux-cpu $(arch) \
--no-goma \
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

bwikbs
bwikbs approved these changes Jul 21, 2021
View reviewed changes
Copy link
Member

@bwikbs bwikbs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good! 👍

@swift-kim swift-kim merged commit 15070da into flutter-tizen:flutter-2.2.1-tizen Jul 23, 2021
swift-kim added a commit that referenced this pull request Sep 27, 2021
@swift-kim
Clean up tizen/BUILD.gn (#150)
d5b5ab9 
* WIP 1

* WIP 2

* Clean up
swift-kim added a commit that referenced this pull request Nov 14, 2021
@swift-kim
Clean up tizen/BUILD.gn (#150)
caf2121 
* WIP 1

* WIP 2

* Clean up
swift-kim added a commit that referenced this pull request Dec 9, 2021
@swift-kim
Clean up tizen/BUILD.gn (#150)
5e5e5a8 
* WIP 1

* WIP 2

* Clean up
swift-kim added a commit that referenced this pull request Dec 17, 2021
@swift-kim
Clean up tizen/BUILD.gn (#150)
1887cdf
swift-kim added a commit that referenced this pull request Feb 7, 2022
@swift-kim
Clean up tizen/BUILD.gn (#150)
bb5c186
swift-kim added a commit that referenced this pull request Feb 11, 2022
@swift-kim
Clean up tizen/BUILD.gn (#150)
35dd3df
swift-kim added a commit that referenced this pull request May 12, 2022
@swift-kim
Clean up tizen/BUILD.gn (#150)
1418b90
swift-kim added a commit that referenced this pull request Aug 5, 2022
@swift-kim
Clean up tizen/BUILD.gn (#150)
f25f312
swift-kim pushed a commit that referenced this pull request Sep 1, 2022
@dnfield
Remove dependency on Dart, add crash handler to impellerc (#150)
8679fe7
swift-kim added a commit that referenced this pull request Sep 1, 2022
@swift-kim
Clean up tizen/BUILD.gn (#150)
383a93c
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bwikbs bwikbs bwikbs approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@swift-kim @bwikbs