Skip to content

Do not call std::locale::global() on startup #151

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 21, 2021
Merged

Do not call std::locale::global() on startup #151

merged 1 commit into from
Jul 21, 2021

Conversation

swift-kim
Copy link
Member

@swift-kim swift-kim commented Jul 21, 2021 •
edited
Loading

Calling std::locale::global(std::locale("")) results in a program crash when the locale is explicitly provided.

e.g.

$ LANG=ja_JP ./flutter_tizen_shell --width=1400 --height=800
Launching a Flutter application...
...
Aborted (core dumped)

@swift-kim swift-kim requested a review from bwikbs July 21, 2021 06:11
bwikbs
bwikbs approved these changes Jul 21, 2021
View reviewed changes
Copy link
Member

@bwikbs bwikbs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I didn't expect this... this part is needed anymore... but it's still there. 😢

@bwikbs bwikbs merged commit ae4fd0d into flutter-tizen:flutter-2.2.1-tizen Jul 21, 2021
swift-kim added a commit that referenced this pull request Sep 27, 2021
@swift-kim
Do not call std::locale::global() on startup (#151)
db1666e
swift-kim added a commit that referenced this pull request Nov 14, 2021
@swift-kim
Do not call std::locale::global() on startup (#151)
8860095
swift-kim added a commit that referenced this pull request Dec 9, 2021
@swift-kim
Do not call std::locale::global() on startup (#151)
3ebc56c
swift-kim added a commit that referenced this pull request Dec 17, 2021
@swift-kim
Do not call std::locale::global() on startup (#151)
52cbef2
swift-kim added a commit that referenced this pull request Feb 7, 2022
@swift-kim
Do not call std::locale::global() on startup (#151)
ba55196
swift-kim added a commit that referenced this pull request Feb 11, 2022
@swift-kim
Do not call std::locale::global() on startup (#151)
220748d
swift-kim added a commit that referenced this pull request May 12, 2022
@swift-kim
Do not call std::locale::global() on startup (#151)
95577b4
swift-kim added a commit that referenced this pull request Aug 5, 2022
@swift-kim
Do not call std::locale::global() on startup (#151)
d33181f
swift-kim pushed a commit that referenced this pull request Sep 1, 2022
@dependabot @dnfield
Bump actions/checkout from 3.0.0 to 3.0.2 (#151)
69b676c 
Bumps [actions/checkout](https://github.com/actions/checkout) from 3.0.0 to 3.0.2.
- [Release notes](https://github.com/actions/checkout/releases)
- [Changelog](https://github.com/actions/checkout/blob/main/CHANGELOG.md)
- [Commits](actions/checkout@a12a394...2541b12)

---
updated-dependencies:
- dependency-name: actions/checkout
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <[email protected]>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
swift-kim added a commit that referenced this pull request Sep 1, 2022
@swift-kim
Do not call std::locale::global() on startup (#151)
9facd9d
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bwikbs bwikbs bwikbs approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@swift-kim @bwikbs