Skip to content

Add SettingsChannel unit test #158

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

bbrto21
Copy link

@bbrto21 bbrto21 commented Jul 29, 2021

  • Take test_binary_messenger.h from Windows implementation

Signed-off-by: Boram Bae [email protected]

@bbrto21 bbrto21 force-pushed the add_setting_channel_unittests branch from 564b766 to d7a5527 Compare July 29, 2021 06:48
Copy link
Member

@swift-kim swift-kim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nicely done!

* Take test_binary_messenger.h from Windows implementation

Signed-off-by: Boram Bae <[email protected]>
@bbrto21 bbrto21 force-pushed the add_setting_channel_unittests branch from d7a5527 to 61a8e2c Compare July 29, 2021 09:24
@swift-kim swift-kim merged commit 102f1e2 into flutter-tizen:flutter-2.2.1-tizen Jul 30, 2021
swift-kim pushed a commit that referenced this pull request Sep 27, 2021
* Take test_binary_messenger.h from Windows implementation

Signed-off-by: Boram Bae <[email protected]>
swift-kim pushed a commit that referenced this pull request Nov 14, 2021
* Take test_binary_messenger.h from Windows implementation

Signed-off-by: Boram Bae <[email protected]>
swift-kim pushed a commit that referenced this pull request Dec 9, 2021
* Take test_binary_messenger.h from Windows implementation

Signed-off-by: Boram Bae <[email protected]>
swift-kim pushed a commit that referenced this pull request Dec 17, 2021
* Take test_binary_messenger.h from Windows implementation

Signed-off-by: Boram Bae <[email protected]>
swift-kim pushed a commit that referenced this pull request Feb 7, 2022
* Take test_binary_messenger.h from Windows implementation

Signed-off-by: Boram Bae <[email protected]>
swift-kim pushed a commit that referenced this pull request Feb 11, 2022
* Take test_binary_messenger.h from Windows implementation

Signed-off-by: Boram Bae <[email protected]>
swift-kim pushed a commit that referenced this pull request May 12, 2022
* Take test_binary_messenger.h from Windows implementation

Signed-off-by: Boram Bae <[email protected]>
swift-kim pushed a commit that referenced this pull request Aug 5, 2022
* Take test_binary_messenger.h from Windows implementation

Signed-off-by: Boram Bae <[email protected]>
swift-kim pushed a commit that referenced this pull request Sep 1, 2022
* Take test_binary_messenger.h from Windows implementation

Signed-off-by: Boram Bae <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants