forked from flutter/engine
-
Notifications
You must be signed in to change notification settings - Fork 17
Make public members of FlutterTizenEngine class private #161
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
swift-kim
merged 2 commits into
flutter-tizen:flutter-2.2.1-tizen
from
swift-kim:accessor
Aug 5, 2021
Merged
Make public members of FlutterTizenEngine class private #161
swift-kim
merged 2 commits into
flutter-tizen:flutter-2.2.1-tizen
from
swift-kim:accessor
Aug 5, 2021
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bbrto21
approved these changes
Aug 3, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
5de5ada
to
2b047e2
Compare
swift-kim
added a commit
that referenced
this pull request
Sep 27, 2021
* Make public members of FlutterTizenEngine class private * Organize includes and clean up
swift-kim
added a commit
that referenced
this pull request
Nov 14, 2021
* Make public members of FlutterTizenEngine class private * Organize includes and clean up
swift-kim
added a commit
that referenced
this pull request
Dec 9, 2021
* Make public members of FlutterTizenEngine class private * Organize includes and clean up
swift-kim
added a commit
that referenced
this pull request
Dec 17, 2021
* Make public members of FlutterTizenEngine class private * Organize includes and clean up
swift-kim
added a commit
that referenced
this pull request
Feb 7, 2022
* Make public members of FlutterTizenEngine class private * Organize includes and clean up
swift-kim
added a commit
that referenced
this pull request
Feb 11, 2022
* Make public members of FlutterTizenEngine class private * Organize includes and clean up
swift-kim
added a commit
that referenced
this pull request
May 12, 2022
* Make public members of FlutterTizenEngine class private * Organize includes and clean up
swift-kim
added a commit
that referenced
this pull request
Aug 5, 2022
* Make public members of FlutterTizenEngine class private * Organize includes and clean up
swift-kim
pushed a commit
that referenced
this pull request
Sep 1, 2022
Earlier, no PerVertexData struct would be generated. The shader is useless without reflection information. Fixes flutter/flutter#102521.
swift-kim
added a commit
that referenced
this pull request
Sep 1, 2022
* Make public members of FlutterTizenEngine class private * Organize includes and clean up
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reason: https://google.github.io/styleguide/cppguide.html#Access_Control
Style rules:
Please do not merge until #154 is merged.