Refactor the key event handling #291
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Boram Bae <[email protected]>
* Remove the window dependency from TizenInputMethodContext Signed-off-by: Boram Bae <[email protected]>
* Removes platform dependencies from all SendKeyEvent methods. * Adds methods related to composing a text to the FlutterView and TextInputChannel. * Transfers the key event filter role to TizenInputMethodContext. * Adds filter methods for each event type to TizenInputMethodContext. * Removes the concept of selection mode for text input. Signed-off-by: Boram Bae <[email protected]>
|
contribute to flutter-tizen/flutter-tizen#351 |
JSUYA
reviewed
May 27, 2022
JSUYA
reviewed
May 30, 2022
swift-kim
reviewed
May 30, 2022
swift-kim
reviewed
May 30, 2022
Comment on lines
208
to
220
| if (text_input_channel_->SendKeyEvent(key, string, compose, modifiers, | ||
| keycode, is_down)) { | ||
| return; | ||
| } | ||
| } | ||
|
|
||
| if (engine_->platform_view_channel()) { | ||
| engine_->platform_view_channel()->SendKeyEvent(event, is_down); | ||
| engine_->platform_view_channel()->SendKeyEvent(key, string, compose, | ||
| modifiers, keycode, is_down); | ||
| } | ||
|
|
||
| if (engine_->key_event_channel()) { | ||
| engine_->key_event_channel()->SendKeyEvent( |
There was a problem hiding this comment.
These SendKeyEvent methods defined by each "channel" class have similar method signatures. How about defining a common interface for them?
It might be hard to define such interface because TextInputChannel's SendKeyEvent is synchronous while KeyEventChannel's SendKeyEvent is asynchronous.
There was a problem hiding this comment.
I already thought about this, but I didn't include it in this PR. because this topic got me thinking too much :(
In the end, I excluded this in order to achieve the purpose of this PR quickly. But it's still on the list I want to refactor.
There was a problem hiding this comment.
Alright. You might take care of this later.
Signed-off-by: Boram Bae <[email protected]>
Signed-off-by: Boram Bae <[email protected]>
JSUYA
reviewed
May 31, 2022
JSUYA
reviewed
May 31, 2022
Signed-off-by: Boram Bae <[email protected]>
bwikbs
approved these changes
May 31, 2022
Signed-off-by: Boram Bae <[email protected]>
JSUYA
approved these changes
May 31, 2022
* From Filter to Handle Signed-off-by: Boram Bae <[email protected]>
Signed-off-by: Boram Bae <[email protected]>
Signed-off-by: Boram Bae <[email protected]>
swift-kim
reviewed
Jun 2, 2022
Signed-off-by: Boram Bae <[email protected]>
bbrto21
force-pushed
the
refactor_key
branch
2 times, most recently
from
3db24b5 to
12d051c
Compare
Signed-off-by: Boram Bae <[email protected]>
bbrto21
commented
Jun 2, 2022
swift-kim
approved these changes
Jun 2, 2022
swift-kim
pushed a commit
that referenced
this pull request
Aug 5, 2022
* Removes platform dependencies from all SendKeyEvent methods. * Adds methods related to composing a text to the FlutterView and TextInputChannel. * Transfers the key event filter role to TizenInputMethodContext. * Adds filter methods for each event type to TizenInputMethodContext. * Removes the concept of selection mode for text input. Signed-off-by: Boram Bae <[email protected]>
swift-kim
pushed a commit
that referenced
this pull request
Sep 1, 2022
* Removes platform dependencies from all SendKeyEvent methods. * Adds methods related to composing a text to the FlutterView and TextInputChannel. * Transfers the key event filter role to TizenInputMethodContext. * Adds filter methods for each event type to TizenInputMethodContext. * Removes the concept of selection mode for text input. Signed-off-by: Boram Bae <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TextInputChannel.