[SystemChrome] setPreferredOrientations implementation added #79
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
[Before] not implemented
[After] Using API below allows to narrow some rotations of application UI
e.g.
/// to limit some orientations
List<DeviceOrientation> orientations = [DeviceOrientation.portraitUp, DeviceOrientation.landscapeLeft];
SystemChrome.setPreferredOrientations(orientations).then(
(value) => print("preferred orientations were set"));
/// to clear previous limitations
List<DeviceOrientation> orientations = [];
SystemChrome.setPreferredOrientations(orientations).then(
(value) => print("preferred orientations were CLEARED"));
pwasowski2
suggested changes
Apr 30, 2021
|
@pwasowski2 Thank you for you feedback. I've applied all your suggestions. |
swift-kim
approved these changes
May 5, 2021
|
@swift-kim I've renamed member name to tizen_renderer_ as you suggested. |
swift-kim
pushed a commit
that referenced
this pull request
Jun 7, 2021
* [SystemChrome] setPreferredOrientations implementation added
[Before] not implemented
[After] Using API below allows to narrow some rotations of application UI
e.g.
/// to limit some orientations
List<DeviceOrientation> orientations = [DeviceOrientation.portraitUp, DeviceOrientation.landscapeLeft];
SystemChrome.setPreferredOrientations(orientations).then(
(value) => print("preferred orientations were set"));
/// to clear previous limitations
List<DeviceOrientation> orientations = [];
SystemChrome.setPreferredOrientations(orientations).then(
(value) => print("preferred orientations were CLEARED"));
* [SystemChrome] setPreferredOrientations implementation added - review fixes
* [SystemChrome] setPreferredOrientations implementation added - changed member name
swift-kim
pushed a commit
that referenced
this pull request
Sep 27, 2021
* [SystemChrome] setPreferredOrientations implementation added
[Before] not implemented
[After] Using API below allows to narrow some rotations of application UI
e.g.
/// to limit some orientations
List<DeviceOrientation> orientations = [DeviceOrientation.portraitUp, DeviceOrientation.landscapeLeft];
SystemChrome.setPreferredOrientations(orientations).then(
(value) => print("preferred orientations were set"));
/// to clear previous limitations
List<DeviceOrientation> orientations = [];
SystemChrome.setPreferredOrientations(orientations).then(
(value) => print("preferred orientations were CLEARED"));
* [SystemChrome] setPreferredOrientations implementation added - review fixes
* [SystemChrome] setPreferredOrientations implementation added - changed member name
swift-kim
pushed a commit
that referenced
this pull request
Nov 14, 2021
* [SystemChrome] setPreferredOrientations implementation added
[Before] not implemented
[After] Using API below allows to narrow some rotations of application UI
e.g.
/// to limit some orientations
List<DeviceOrientation> orientations = [DeviceOrientation.portraitUp, DeviceOrientation.landscapeLeft];
SystemChrome.setPreferredOrientations(orientations).then(
(value) => print("preferred orientations were set"));
/// to clear previous limitations
List<DeviceOrientation> orientations = [];
SystemChrome.setPreferredOrientations(orientations).then(
(value) => print("preferred orientations were CLEARED"));
* [SystemChrome] setPreferredOrientations implementation added - review fixes
* [SystemChrome] setPreferredOrientations implementation added - changed member name
swift-kim
pushed a commit
that referenced
this pull request
Dec 9, 2021
* [SystemChrome] setPreferredOrientations implementation added
[Before] not implemented
[After] Using API below allows to narrow some rotations of application UI
e.g.
/// to limit some orientations
List<DeviceOrientation> orientations = [DeviceOrientation.portraitUp, DeviceOrientation.landscapeLeft];
SystemChrome.setPreferredOrientations(orientations).then(
(value) => print("preferred orientations were set"));
/// to clear previous limitations
List<DeviceOrientation> orientations = [];
SystemChrome.setPreferredOrientations(orientations).then(
(value) => print("preferred orientations were CLEARED"));
* [SystemChrome] setPreferredOrientations implementation added - review fixes
* [SystemChrome] setPreferredOrientations implementation added - changed member name
swift-kim
pushed a commit
that referenced
this pull request
Dec 17, 2021
[Before] not implemented
[After] Using API below allows to narrow some rotations of application UI
e.g.
/// to limit some orientations
List<DeviceOrientation> orientations = [DeviceOrientation.portraitUp, DeviceOrientation.landscapeLeft];
SystemChrome.setPreferredOrientations(orientations).then(
(value) => print("preferred orientations were set"));
/// to clear previous limitations
List<DeviceOrientation> orientations = [];
SystemChrome.setPreferredOrientations(orientations).then(
(value) => print("preferred orientations were CLEARED"));
swift-kim
pushed a commit
that referenced
this pull request
Feb 7, 2022
[Before] not implemented
[After] Using API below allows to narrow some rotations of application UI
e.g.
/// to limit some orientations
List<DeviceOrientation> orientations = [DeviceOrientation.portraitUp, DeviceOrientation.landscapeLeft];
SystemChrome.setPreferredOrientations(orientations).then(
(value) => print("preferred orientations were set"));
/// to clear previous limitations
List<DeviceOrientation> orientations = [];
SystemChrome.setPreferredOrientations(orientations).then(
(value) => print("preferred orientations were CLEARED"));
swift-kim
pushed a commit
that referenced
this pull request
Feb 11, 2022
[Before] not implemented
[After] Using API below allows to narrow some rotations of application UI
e.g.
/// to limit some orientations
List<DeviceOrientation> orientations = [DeviceOrientation.portraitUp, DeviceOrientation.landscapeLeft];
SystemChrome.setPreferredOrientations(orientations).then(
(value) => print("preferred orientations were set"));
/// to clear previous limitations
List<DeviceOrientation> orientations = [];
SystemChrome.setPreferredOrientations(orientations).then(
(value) => print("preferred orientations were CLEARED"));
swift-kim
pushed a commit
that referenced
this pull request
May 12, 2022
[Before] not implemented
[After] Using API below allows to narrow some rotations of application UI
e.g.
/// to limit some orientations
List<DeviceOrientation> orientations = [DeviceOrientation.portraitUp, DeviceOrientation.landscapeLeft];
SystemChrome.setPreferredOrientations(orientations).then(
(value) => print("preferred orientations were set"));
/// to clear previous limitations
List<DeviceOrientation> orientations = [];
SystemChrome.setPreferredOrientations(orientations).then(
(value) => print("preferred orientations were CLEARED"));
swift-kim
pushed a commit
that referenced
this pull request
Aug 5, 2022
[Before] not implemented
[After] Using API below allows to narrow some rotations of application UI
e.g.
/// to limit some orientations
List<DeviceOrientation> orientations = [DeviceOrientation.portraitUp, DeviceOrientation.landscapeLeft];
SystemChrome.setPreferredOrientations(orientations).then(
(value) => print("preferred orientations were set"));
/// to clear previous limitations
List<DeviceOrientation> orientations = [];
SystemChrome.setPreferredOrientations(orientations).then(
(value) => print("preferred orientations were CLEARED"));
swift-kim
pushed a commit
that referenced
this pull request
Sep 1, 2022
Offset is a uint64_t that needs a cast.
swift-kim
pushed a commit
that referenced
this pull request
Sep 1, 2022
[Before] not implemented
[After] Using API below allows to narrow some rotations of application UI
e.g.
/// to limit some orientations
List<DeviceOrientation> orientations = [DeviceOrientation.portraitUp, DeviceOrientation.landscapeLeft];
SystemChrome.setPreferredOrientations(orientations).then(
(value) => print("preferred orientations were set"));
/// to clear previous limitations
List<DeviceOrientation> orientations = [];
SystemChrome.setPreferredOrientations(orientations).then(
(value) => print("preferred orientations were CLEARED"));
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[Before] not implemented
[After] Using API below allows to narrow some rotations of application UI
e.g.
/// to limit some orientations
List orientations = [DeviceOrientation.portraitUp, DeviceOrientation.landscapeLeft];
SystemChrome.setPreferredOrientations(orientations).then(
(value) => print("preferred orientations were set"));
/// to clear previous limitations
List orientations = [];
SystemChrome.setPreferredOrientations(orientations).then(
(value) => print("preferred orientations were CLEARED"));
This PR is related to part of https://github.sec.samsung.net/f-project/home/issues/35:
Even though there's no corresponding Tizen system API for locking the app orientation, can't we somehow manage the desired orientation information in the embedder to use with TizenEmbedderEngine::SetWindowOrientation? I think we should investigate this particular method in more details because many apps may want to use a fixed orientation.