Support SystemSound.play() #84
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Please, resolve conflict |
swift-kim
reviewed
May 11, 2021
….play() Signed-off-by: Pawel Wasowski <[email protected]>
pwasowski2
force-pushed
the
SystemSound.play
branch
from
4880add to
39cc02e
Compare
|
I have resolved all the conflicts that occurred after merging #75 I kindly request for your review :) |
swift-kim
approved these changes
May 11, 2021
bbrto21
approved these changes
May 12, 2021
swift-kim
pushed a commit
that referenced
this pull request
Jun 7, 2021
….play() (#84) Signed-off-by: Pawel Wasowski <[email protected]>
swift-kim
pushed a commit
that referenced
this pull request
Sep 27, 2021
….play() (#84) Signed-off-by: Pawel Wasowski <[email protected]>
swift-kim
pushed a commit
that referenced
this pull request
Nov 14, 2021
….play() (#84) Signed-off-by: Pawel Wasowski <[email protected]>
swift-kim
pushed a commit
that referenced
this pull request
Dec 9, 2021
….play() (#84) Signed-off-by: Pawel Wasowski <[email protected]>
swift-kim
pushed a commit
that referenced
this pull request
Dec 17, 2021
….play() (#84) Signed-off-by: Pawel Wasowski <[email protected]>
swift-kim
pushed a commit
that referenced
this pull request
Feb 7, 2022
….play() (#84) Signed-off-by: Pawel Wasowski <[email protected]>
swift-kim
pushed a commit
that referenced
this pull request
Feb 11, 2022
….play() (#84) Signed-off-by: Pawel Wasowski <[email protected]>
swift-kim
pushed a commit
that referenced
this pull request
May 12, 2022
….play() (#84) Signed-off-by: Pawel Wasowski <[email protected]>
swift-kim
pushed a commit
that referenced
this pull request
Aug 5, 2022
….play() (#84) Signed-off-by: Pawel Wasowski <[email protected]>
swift-kim
pushed a commit
that referenced
this pull request
Sep 1, 2022
swift-kim
pushed a commit
that referenced
this pull request
Sep 1, 2022
….play() (#84) Signed-off-by: Pawel Wasowski <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds support for SystemSound.play() (resolves #77) and does a minor refactoring of shell/platform/tizen/channels/platform_channel.cc.
This PR depends on #75 and should be merged after it.