Skip to content

Set a proper version for the generated rootstrap definition #204

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 19, 2021

Conversation

swift-kim
Copy link
Member

Contributes to #143.

The version attribute of the generated rootstrap definition is used as part of the output TPK name when building a multi app. This change lets the attribute have a meaningful value.

# Before:
com.example.multi_app_flutter-null_armel_Debug.tpk

# After:
com.example.multi_app_Tizen-4.0_armel_Debug.tpk

@swift-kim swift-kim changed the title Set a proper version value for the generated rootstrap definition Set a proper version for the generated rootstrap definition Aug 18, 2021
Copy link
Member

@bwikbs bwikbs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I didn't understand where it is used... but it looks better than now.

@bbrto21 bbrto21 merged commit 6942f26 into flutter-tizen:master Aug 19, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants