Enable the simultaneous use of Dart plugins and custom Dart entrypoints #228
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
swift-kim
force-pushed
the
fix-service-entrypoints
branch
from
d508f1c to
35414f0
Compare
swift-kim
force-pushed
the
fix-service-entrypoints
branch
from
35414f0 to
101d472
Compare
bbrto21
approved these changes
Sep 6, 2021
swift-kim
added a commit
to swift-kim/flutter-tizen
that referenced
this pull request
Oct 20, 2021
…ntrypoints (flutter-tizen#228)" This reverts commit 62dbcf3.
swift-kim
added a commit
that referenced
this pull request
Oct 21, 2021
* Update Dart plugin registrant * Clean up * Remove TizenAnalyzeCommand * Clean up tizen_plugins.dart and expose renderTemplateToFile * Update test.dart * Additional clean-up * Revert "Enable the simultaneous use of Dart plugins and custom Dart entrypoints (#228)" This reverts commit 62dbcf3. * Reimplement multiple Dart entrypoints support * Remove analyzer from dependencies
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Find entry points functions from the main dart file and inject to the generated main file.
Resolves the limitation mentioned in #171 ("The use of custom entrypoints may break ...").
Note that this change doesn't take account of all possible uses of the
vm:entry-pointpragma described in https://github.com/dart-lang/sdk/blob/master/runtime/docs/compiler/aot/entry_point_pragma.md#syntax. Only functions are allowed and the second parameter of@pragmais not honored.@jkpu @pkosko
See also: The AST analyzer (https://github.com/dart-lang/sdk/blob/master/pkg/analyzer/doc/tutorial/ast.md)