Add platform view support to flutter_tizen #462
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* This is from the webview_flutter plugin. * Mimic original flutter lib's directory structure. Signed-off-by: Boram Bae <[email protected]>
|
How about this PR? I just moved this from |
bwikbs
approved these changes
Nov 14, 2022
Thanks to @swift-kim |
Signed-off-by: Boram Bae <[email protected]>
|
Please provide something like flutter-tizen/plugins#54 (review) so that we can track the original source code and make updates later. I think now is the good chance to sync the latest source code from the framework but not just copy the old webview_flutter's code. |
Signed-off-by: Boram Bae <[email protected]>
* Keep syncing this to bin/internal/flutter.version after this patch. Signed-off-by: Boram Bae <[email protected]>
|
@swift-kim I added sources and update implementations to the latest. |
Signed-off-by: Boram Bae <[email protected]>
bbrto21
force-pushed
the
platform_view
branch
from
4037c43 to
09fd9ea
Compare
swift-kim
reviewed
Nov 16, 2022
| // Use of this source code is governed by a BSD-style license that can be | ||
| // found in the LICENSE file. | ||
|
|
||
| // ignore_for_file: public_member_api_docs |
There was a problem hiding this comment.
This might be removed in the future.
Signed-off-by: Boram Bae <[email protected]>
Signed-off-by: Boram Bae <[email protected]>
Signed-off-by: Boram Bae <[email protected]>
Signed-off-by: Boram Bae <[email protected]>
Signed-off-by: Boram Bae <[email protected]>
Signed-off-by: Boram Bae <[email protected]>
Signed-off-by: Boram Bae <[email protected]>
bbrto21
force-pushed
the
platform_view
branch
from
a52b542 to
29fbcee
Compare
swift-kim
approved these changes
Nov 16, 2022
bbrto21
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
platform_viewto latest influtterSigned-off-by: Boram Bae [email protected]