[multi-packages] Fix issues from static analysis (#264)

* Missing break
* Uninitialized field
* Incorrect comparison

Signed-off-by: MuHong Byun <[email protected]>

Author: bwikbs

packages/battery/tizen/src/battery_tizen_plugin.cc

@@ -194,7 +194,7 @@ class BatteryTizenPlugin : public flutter::Plugin {
   std::unique_ptr<flutter::EventChannel<flutter::EncodableValue>>
       event_channel_;
   std::unique_ptr<flutter::EventSink<flutter::EncodableValue>> events_;
-  bool is_full_;
+  bool is_full_ = false;
 };
 
 void BatteryTizenPluginRegisterWithRegistrar(

packages/battery_plus/tizen/src/battery_plus_tizen_plugin.cc

@@ -194,7 +194,7 @@ class BatteryPlusTizenPlugin : public flutter::Plugin {
   std::unique_ptr<flutter::EventChannel<flutter::EncodableValue>>
       event_channel_;
   std::unique_ptr<flutter::EventSink<flutter::EncodableValue>> events_;
-  bool is_full_;
+  bool is_full_ = false;
 };
 
 void BatteryPlusTizenPluginRegisterWithRegistrar(

packages/camera/tizen/src/camera_device.cc

@@ -94,6 +94,7 @@ static RecorderOrientationTag ChooseRecorderOrientationTag(
       break;
     case OrientationType::kLandscapeRight:
       tag = RecorderOrientationTag::kNone;
+      break;
     default:
       LOG_ERROR("Unknown RecorderOrientationTag!");
       break;

packages/image_picker/tizen/src/image_resize.h

@@ -19,9 +19,9 @@ class ImageResize {
                       image_util_image_h& dst_image);
   bool EncodeImage(image_util_encode_h encode_h, image_util_image_h dst_image,
                    image_util_type_e encoder_type, const std::string& dst_file);
-  unsigned int max_width_;
-  unsigned int max_height_;
-  int quality_;
+  unsigned int max_width_ = 0;
+  unsigned int max_height_ = 0;
+  int quality_ = 0;
 };
 
 #endif

packages/webview_flutter/tizen/src/webview.cc

@@ -323,7 +323,7 @@ void WebView::ApplySettings(flutter::EncodableMap settings) {
         // NOTE: Not supported by LWE on Tizen.
       } else if ("gestureNavigationEnabled" == k) {
         // NOTE: Not supported by LWE on Tizen.
-      } else if ("allowsInlineMediaPlayback") {
+      } else if ("allowsInlineMediaPlayback" == k) {
         // no-op inline media playback is always allowed on Tizen.
       } else if ("userAgent" == k) {
         if (std::holds_alternative<std::string>(val)) {