Skip to content

[multi-packages] Fix issues from static analysis #264

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 10, 2021

Conversation

bwikbs
Copy link
Member

@bwikbs bwikbs commented Nov 5, 2021

Fix following issue:

  • Missing break
  • Uninitialized field
  • Incorrect comparison

Signed-off-by: MuHong Byun [email protected]

* Missing break
* Uninitialized field
* Incorrect comparison

Signed-off-by: MuHong Byun <[email protected]>
@HakkyuKim
Copy link
Contributor

In case of webview_flutter, I believe it should be published since it's a bug that affects functionality.

@seungsoo47 seungsoo47 merged commit f986a25 into flutter-tizen:master Nov 10, 2021
@swift-kim
Copy link
Member

This PR was marked ready for review only 2 hours ago. You're too quick. @seungsoo47

@bwikbs
Copy link
Member Author

bwikbs commented Nov 10, 2021

@swift-kim
It's kind of misunderstanding me and @seungsoo47 😢

@seungsoo47
Copy link
Contributor

Oh. I am sorry. It's my mistake. @swift-kim

@bwikbs
Copy link
Member Author

bwikbs commented Nov 10, 2021

In case of webview_flutter, I believe it should be published since it's a bug that affects functionality.

This will be done at #246.

bwikbs added a commit to bwikbs/plugins that referenced this pull request Mar 26, 2022
* Missing break
* Uninitialized field
* Incorrect comparison

Signed-off-by: MuHong Byun <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants