Skip to content

[webview_flutter] Update minor things #118

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Jun 7, 2021

Conversation

bwikbs
Copy link
Member

@bwikbs bwikbs commented Jun 1, 2021

  • Update lightweight web engine binary
  • Update version && change log
  • Enable resize function

Signed-off-by: MuHong Byun [email protected]

* Update lightweight web engine binary
* Update version && change log
* Enable resize function

Signed-off-by: MuHong Byun <[email protected]>
@bwikbs bwikbs requested a review from a team June 1, 2021 06:20
@bwikbs
Copy link
Member Author

bwikbs commented Jun 1, 2021

Require flutter-tizen/engine#103

@bwikbs bwikbs requested review from pkosko and swift-kim June 1, 2021 06:22
Copy link
Member

@swift-kim swift-kim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You included an armel binary in the lib/aarch64 directory.

@swift-kim
Copy link
Member

Please update the package versions in the Usage section in README.

@swift-kim
Copy link
Member

swift-kim commented Jun 1, 2021

I encountered the following error (undefined reference to LWE::LWE::Finalize()) when building an example app. What could have been done wrong?

  Building target: Release/libflutter_plugins.so
  Invoking: C/C++ Linker
"/home/swift/tizen-studio/tools/smart-build-interface/../llvm-10/bin/clang++" -o ./Release/libflutter_plugins.so @./Release/target_objs.file   -Llib
-L"/tmp/flutter_tools.TLGPTW/0/lib" -Wl,--no-undefined -s -Wl,-rpath='$ORIGIN' -target arm-tizen-linux-gnueabi -gcc-toolchain
"/home/swift/tizen-studio/tools/smart-build-interface/../arm-linux-gnueabi-gcc-9.2/" -ccc-gcc-name arm-linux-gnueabi-g++ -march=armv7-a -mfloat-abi=softfp
-mfpu=vfpv3-d16 -mtune=cortex-a8 -Wl,-z,relro,--as-needed -static-libstdc++ -Xlinker --as-needed -shared -lpthread
--sysroot="/home/swift/tizen-studio/tools/smart-build-interface/../../platforms/tizen-5.5/wearable/rootstraps/wearable-5.5-device.core"
-L/home/swift/tizen-studio/platforms/tizen-5.5/wearable/rootstraps/wearable-5.5-device.core/usr/lib @./Release/platform_libs.file -lflutter_tizen_wearable
-L"/home/swift/Git/flutter/flutter-tizen/bin/cache/artifacts/engine/tizen-arm-release" -fvisibility=hidden -std=c++17
-I"/home/swift/Git/flutter/flutter-tizen/bin/cache/artifacts/engine/common/cpp_client_wrapper/include"
-I"/home/swift/Git/flutter/flutter-tizen/bin/cache/artifacts/engine/common/public" -I"/home/swift/Git/flutter/plugins/packages/integration_test/tizen/inc"
-I"/home/swift/Git/flutter/plugins/packages/integration_test/tizen/src" -I"/home/swift/Git/flutter/plugins/packages/webview_flutter/tizen/inc"
-I"/home/swift/Git/flutter/plugins/packages/webview_flutter/tizen/src"
-L"/home/swift/Git/flutter/plugins/packages/webview_flutter/example/.dart_tool/flutter_build/145a4886132ee1c4be3471b4c0a870be/tizen_plugins/lib"
-DWEARABLE_PROFILE
/home/swift/tizen-studio/tools/smart-build-interface/../arm-linux-gnueabi-gcc-9.2/lib/gcc/arm-tizen-linux-gnueabi/9.2.0/../../../../arm-tizen-linux-gnueabi/bin/
ld: ./Release//home/swift/Git/flutter/plugins/packages/webview_flutter/tizen/src/webview.o: in function `WebView::WebView(flutter::PluginRegistrar*, int,
flutter::TextureRegistrar*, double, double, std::map<flutter::EncodableValue, flutter::EncodableValue, std::less<flutter::EncodableValue>,
std::allocator<std::pair<flutter::EncodableValue const, flutter::EncodableValue> > >&)':
webview.cc:(.text+0x1370): undefined reference to `LWE::WebContainer::GetSettings()'
/home/swift/tizen-studio/tools/smart-build-interface/../arm-linux-gnueabi-gcc-9.2/lib/gcc/arm-tizen-linux-gnueabi/9.2.0/../../../../arm-tizen-linux-gnueabi/bin/
ld: webview.cc:(.text+0x1388): undefined reference to `LWE::Settings::SetUserAgentString(std::__cxx11::basic_string<char, std::char_traits<char>,
std::allocator<char> > const&)'
/home/swift/tizen-studio/tools/smart-build-interface/../arm-linux-gnueabi-gcc-9.2/lib/gcc/arm-tizen-linux-gnueabi/9.2.0/../../../../arm-tizen-linux-gnueabi/bin/
ld: webview.cc:(.text+0x1398): undefined reference to `LWE::WebContainer::SetSettings(LWE::Settings const&)'
/home/swift/tizen-studio/tools/smart-build-interface/../arm-linux-gnueabi-gcc-9.2/lib/gcc/arm-tizen-linux-gnueabi/9.2.0/../../../../arm-tizen-linux-gnueabi/bin/
ld: webview.cc:(.text+0x13fc): undefined reference to `LWE::WebContainer::RegisterOnPageStartedHandler(std::function<void (LWE::WebContainer*,
std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > const&)> const&)'
/home/swift/tizen-studio/tools/smart-build-interface/../arm-linux-gnueabi-gcc-9.2/lib/gcc/arm-tizen-linux-gnueabi/9.2.0/../../../../arm-tizen-linux-gnueabi/bin/
ld: webview.cc:(.text+0x1440): undefined reference to `LWE::WebContainer::RegisterOnPageLoadedHandler(std::function<void (LWE::WebContainer*,
std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > const&)>)'
/home/swift/tizen-studio/tools/smart-build-interface/../arm-linux-gnueabi-gcc-9.2/lib/gcc/arm-tizen-linux-gnueabi/9.2.0/../../../../arm-tizen-linux-gnueabi/bin/
ld: webview.cc:(.text+0x1484): undefined reference to `LWE::WebContainer::RegisterOnProgressChangedHandler(std::function<void (LWE::WebContainer*, int)>
const&)'
/home/swift/tizen-studio/tools/smart-build-interface/../arm-linux-gnueabi-gcc-9.2/lib/gcc/arm-tizen-linux-gnueabi/9.2.0/../../../../arm-tizen-linux-gnueabi/bin/
ld: webview.cc:(.text+0x14c8): undefined reference to `LWE::WebContainer::RegisterOnReceivedErrorHandler(std::function<void (LWE::WebContainer*,
LWE::ResourceError)> const&)'
/home/swift/tizen-studio/tools/smart-build-interface/../arm-linux-gnueabi-gcc-9.2/lib/gcc/arm-tizen-linux-gnueabi/9.2.0/../../../../arm-tizen-linux-gnueabi/bin/
ld: webview.cc:(.text+0x150c): undefined reference to `LWE::WebContainer::RegisterShouldOverrideUrlLoadingHandler(std::function<bool (LWE::WebContainer*,
std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > const&)> const&)'
/home/swift/tizen-studio/tools/smart-build-interface/../arm-linux-gnueabi-gcc-9.2/lib/gcc/arm-tizen-linux-gnueabi/9.2.0/../../../../arm-tizen-linux-gnueabi/bin/
ld: webview.cc:(.text+0x1534): undefined reference to `LWE::WebContainer::LoadURL(std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char>
> const&)'
/home/swift/tizen-studio/tools/smart-build-interface/../arm-linux-gnueabi-gcc-9.2/lib/gcc/arm-tizen-linux-gnueabi/9.2.0/../../../../arm-tizen-linux-gnueabi/bin/
ld: ./Release//home/swift/Git/flutter/plugins/packages/webview_flutter/tizen/src/webview.o: in function `WebView::InitWebView()':
webview.cc:(.text+0x1de4): undefined reference to `LWE::WebContainer::Destroy()'
/home/swift/tizen-studio/tools/smart-build-interface/../arm-linux-gnueabi-gcc-9.2/lib/gcc/arm-tizen-linux-gnueabi/9.2.0/../../../../arm-tizen-linux-gnueabi/bin/
ld: webview.cc:(.text+0x1ea8): undefined reference to `createWebViewInstance'
/home/swift/tizen-studio/tools/smart-build-interface/../arm-linux-gnueabi-gcc-9.2/lib/gcc/arm-tizen-linux-gnueabi/9.2.0/../../../../arm-tizen-linux-gnueabi/bin/
ld: webview.cc:(.text+0x1ef0): undefined reference to `LWE::WebContainer::GetSettings()'
/home/swift/tizen-studio/tools/smart-build-interface/../arm-linux-gnueabi-gcc-9.2/lib/gcc/arm-tizen-linux-gnueabi/9.2.0/../../../../arm-tizen-linux-gnueabi/bin/
ld: webview.cc:(.text+0x1f48): undefined reference to `LWE::Settings::SetUserAgentString(std::__cxx11::basic_string<char, std::char_traits<char>,
std::allocator<char> > const&)'
/home/swift/tizen-studio/tools/smart-build-interface/../arm-linux-gnueabi-gcc-9.2/lib/gcc/arm-tizen-linux-gnueabi/9.2.0/../../../../arm-tizen-linux-gnueabi/bin/
ld: webview.cc:(.text+0x1f68): undefined reference to `LWE::WebContainer::SetSettings(LWE::Settings const&)'
/home/swift/tizen-studio/tools/smart-build-interface/../arm-linux-gnueabi-gcc-9.2/lib/gcc/arm-tizen-linux-gnueabi/9.2.0/../../../../arm-tizen-linux-gnueabi/bin/
ld: ./Release//home/swift/Git/flutter/plugins/packages/webview_flutter/tizen/src/webview.o: in function
`WebView::RegisterJavaScriptChannelName(std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > const&)':
webview.cc:(.text+0x2618): undefined reference to `LWE::WebContainer::AddJavaScriptInterface(std::__cxx11::basic_string<char, std::char_traits<char>,
std::allocator<char> > const&, std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > const&,
std::function<std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > (std::__cxx11::basic_string<char, std::char_traits<char>,
std::allocator<char> > const&)>)'
/home/swift/tizen-studio/tools/smart-build-interface/../arm-linux-gnueabi-gcc-9.2/lib/gcc/arm-tizen-linux-gnueabi/9.2.0/../../../../arm-tizen-linux-gnueabi/bin/
ld: ./Release//home/swift/Git/flutter/plugins/packages/webview_flutter/tizen/src/webview.o: in function `WebView::Dispose()':
webview.cc:(.text+0x28cc): undefined reference to `LWE::WebContainer::Destroy()'
/home/swift/tizen-studio/tools/smart-build-interface/../arm-linux-gnueabi-gcc-9.2/lib/gcc/arm-tizen-linux-gnueabi/9.2.0/../../../../arm-tizen-linux-gnueabi/bin/
ld: ./Release//home/swift/Git/flutter/plugins/packages/webview_flutter/tizen/src/webview.o: in function `WebView::Resize(double, double)':
webview.cc:(.text+0x29f8): undefined reference to `LWE::WebContainer::ResizeTo(unsigned int, unsigned int)'
/home/swift/tizen-studio/tools/smart-build-interface/../arm-linux-gnueabi-gcc-9.2/lib/gcc/arm-tizen-linux-gnueabi/9.2.0/../../../../arm-tizen-linux-gnueabi/bin/
ld: ./Release//home/swift/Git/flutter/plugins/packages/webview_flutter/tizen/src/webview.o: in function `WebView::Touch(int, int, double, double, double,
double)':
webview.cc:(.text+0x2a54): undefined reference to `LWE::WebContainer::DispatchMouseDownEvent(LWE::MouseButtonValue, LWE::MouseButtonsValue, double, double)'
/home/swift/tizen-studio/tools/smart-build-interface/../arm-linux-gnueabi-gcc-9.2/lib/gcc/arm-tizen-linux-gnueabi/9.2.0/../../../../arm-tizen-linux-gnueabi/bin/
ld: webview.cc:(.text+0x2a74): undefined reference to `LWE::WebContainer::DispatchMouseUpEvent(LWE::MouseButtonValue, LWE::MouseButtonsValue, double, double)'
/home/swift/tizen-studio/tools/smart-build-interface/../arm-linux-gnueabi-gcc-9.2/lib/gcc/arm-tizen-linux-gnueabi/9.2.0/../../../../arm-tizen-linux-gnueabi/bin/
ld: webview.cc:(.text+0x2a98): undefined reference to `LWE::WebContainer::DispatchMouseMoveEvent(LWE::MouseButtonValue, LWE::MouseButtonsValue, double, double)'
/home/swift/tizen-studio/tools/smart-build-interface/../arm-linux-gnueabi-gcc-9.2/lib/gcc/arm-tizen-linux-gnueabi/9.2.0/../../../../arm-tizen-linux-gnueabi/bin/
ld: ./Release//home/swift/Git/flutter/plugins/packages/webview_flutter/tizen/src/webview.o: in function `WebView::DispatchKeyDownEvent(_Ecore_Event_Key*)':
webview.cc:(.text+0x2c24): undefined reference to `LWE::WebContainer::AddIdleCallback(void (*)(void*), void*)'
/home/swift/tizen-studio/tools/smart-build-interface/../arm-linux-gnueabi-gcc-9.2/lib/gcc/arm-tizen-linux-gnueabi/9.2.0/../../../../arm-tizen-linux-gnueabi/bin/
ld: webview.cc:(.text+0x2c64): undefined reference to `LWE::WebContainer::AddIdleCallback(void (*)(void*), void*)'
/home/swift/tizen-studio/tools/smart-build-interface/../arm-linux-gnueabi-gcc-9.2/lib/gcc/arm-tizen-linux-gnueabi/9.2.0/../../../../arm-tizen-linux-gnueabi/bin/
ld: webview.cc:(.text+0x2cac): undefined reference to `LWE::WebContainer::AddIdleCallback(void (*)(void*), void*)'
/home/swift/tizen-studio/tools/smart-build-interface/../arm-linux-gnueabi-gcc-9.2/lib/gcc/arm-tizen-linux-gnueabi/9.2.0/../../../../arm-tizen-linux-gnueabi/bin/
ld: ./Release//home/swift/Git/flutter/plugins/packages/webview_flutter/tizen/src/webview.o: in function `WebView::DispatchKeyUpEvent(_Ecore_Event_Key*)':
webview.cc:(.text+0x3854): undefined reference to `LWE::WebContainer::AddIdleCallback(void (*)(void*), void*)'
/home/swift/tizen-studio/tools/smart-build-interface/../arm-linux-gnueabi-gcc-9.2/lib/gcc/arm-tizen-linux-gnueabi/9.2.0/../../../../arm-tizen-linux-gnueabi/bin/
ld: ./Release//home/swift/Git/flutter/plugins/packages/webview_flutter/tizen/src/webview.o: in function `WebView::DispatchCompositionUpdateEvent(char const*,
int)':
webview.cc:(.text+0x39ec): undefined reference to `LWE::WebContainer::DispatchCompositionUpdateEvent(std::__cxx11::basic_string<char, std::char_traits<char>,
std::allocator<char> > const&)'
/home/swift/tizen-studio/tools/smart-build-interface/../arm-linux-gnueabi-gcc-9.2/lib/gcc/arm-tizen-linux-gnueabi/9.2.0/../../../../arm-tizen-linux-gnueabi/bin/
ld: ./Release//home/swift/Git/flutter/plugins/packages/webview_flutter/tizen/src/webview.o: in function `WebView::DispatchCompositionEndEvent(char const*,
int)':
webview.cc:(.text+0x3b34): undefined reference to `LWE::WebContainer::DispatchCompositionEndEvent(std::__cxx11::basic_string<char, std::char_traits<char>,
std::allocator<char> > const&)'
/home/swift/tizen-studio/tools/smart-build-interface/../arm-linux-gnueabi-gcc-9.2/lib/gcc/arm-tizen-linux-gnueabi/9.2.0/../../../../arm-tizen-linux-gnueabi/bin/
ld: ./Release//home/swift/Git/flutter/plugins/packages/webview_flutter/tizen/src/webview.o: in function
`WebView::SetSoftwareKeyboardContext(_Ecore_IMF_Context*)':
webview.cc:(.text+0x3d4c): undefined reference to `LWE::WebContainer::RegisterOnShowSoftwareKeyboardIfPossibleHandler(std::function<void (LWE::WebContainer*)>
const&)'
/home/swift/tizen-studio/tools/smart-build-interface/../arm-linux-gnueabi-gcc-9.2/lib/gcc/arm-tizen-linux-gnueabi/9.2.0/../../../../arm-tizen-linux-gnueabi/bin/
ld: webview.cc:(.text+0x3d90): undefined reference to `LWE::WebContainer::RegisterOnHideSoftwareKeyboardIfPossibleHandler(std::function<void
(LWE::WebContainer*)> const&)'
/home/swift/tizen-studio/tools/smart-build-interface/../arm-linux-gnueabi-gcc-9.2/lib/gcc/arm-tizen-linux-gnueabi/9.2.0/../../../../arm-tizen-linux-gnueabi/bin/
ld: ./Release//home/swift/Git/flutter/plugins/packages/webview_flutter/tizen/src/webview.o: in function
`WebView::HandleMethodCall(flutter::MethodCall<flutter::EncodableValue> const&, std::unique_ptr<flutter::MethodResult<flutter::EncodableValue>,
std::default_delete<flutter::MethodResult<flutter::EncodableValue> > >)':
webview.cc:(.text+0x4260): undefined reference to `LWE::WebContainer::LoadURL(std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> >
const&)'
/home/swift/tizen-studio/tools/smart-build-interface/../arm-linux-gnueabi-gcc-9.2/lib/gcc/arm-tizen-linux-gnueabi/9.2.0/../../../../arm-tizen-linux-gnueabi/bin/
ld: webview.cc:(.text+0x43d8): undefined reference to `LWE::WebContainer::CanGoBack()'
/home/swift/tizen-studio/tools/smart-build-interface/../arm-linux-gnueabi-gcc-9.2/lib/gcc/arm-tizen-linux-gnueabi/9.2.0/../../../../arm-tizen-linux-gnueabi/bin/
ld: webview.cc:(.text+0x442c): undefined reference to `LWE::WebContainer::CanGoForward()'
/home/swift/tizen-studio/tools/smart-build-interface/../arm-linux-gnueabi-gcc-9.2/lib/gcc/arm-tizen-linux-gnueabi/9.2.0/../../../../arm-tizen-linux-gnueabi/bin/
ld: webview.cc:(.text+0x447c): undefined reference to `LWE::WebContainer::GoBack()'
/home/swift/tizen-studio/tools/smart-build-interface/../arm-linux-gnueabi-gcc-9.2/lib/gcc/arm-tizen-linux-gnueabi/9.2.0/../../../../arm-tizen-linux-gnueabi/bin/
ld: webview.cc:(.text+0x449c): undefined reference to `LWE::WebContainer::GoForward()'
/home/swift/tizen-studio/tools/smart-build-interface/../arm-linux-gnueabi-gcc-9.2/lib/gcc/arm-tizen-linux-gnueabi/9.2.0/../../../../arm-tizen-linux-gnueabi/bin/
ld: webview.cc:(.text+0x44bc): undefined reference to `LWE::WebContainer::Reload()'
/home/swift/tizen-studio/tools/smart-build-interface/../arm-linux-gnueabi-gcc-9.2/lib/gcc/arm-tizen-linux-gnueabi/9.2.0/../../../../arm-tizen-linux-gnueabi/bin/
ld: webview.cc:(.text+0x44e8): undefined reference to `LWE::WebContainer::GetURL[abi:cxx11]()'
/home/swift/tizen-studio/tools/smart-build-interface/../arm-linux-gnueabi-gcc-9.2/lib/gcc/arm-tizen-linux-gnueabi/9.2.0/../../../../arm-tizen-linux-gnueabi/bin/
ld: webview.cc:(.text+0x4794): undefined reference to `LWE::WebContainer::ClearCache()'
/home/swift/tizen-studio/tools/smart-build-interface/../arm-linux-gnueabi-gcc-9.2/lib/gcc/arm-tizen-linux-gnueabi/9.2.0/../../../../arm-tizen-linux-gnueabi/bin/
ld: webview.cc:(.text+0x4800): undefined reference to `LWE::WebContainer::EvaluateJavaScript(std::__cxx11::basic_string<char, std::char_traits<char>,
std::allocator<char> > const&, std::function<void (std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > const&)>)'
/home/swift/tizen-studio/tools/smart-build-interface/../arm-linux-gnueabi-gcc-9.2/lib/gcc/arm-tizen-linux-gnueabi/9.2.0/../../../../arm-tizen-linux-gnueabi/bin/
ld: webview.cc:(.text+0x4840): undefined reference to `LWE::WebContainer::GetTitle[abi:cxx11]()'
/home/swift/tizen-studio/tools/smart-build-interface/../arm-linux-gnueabi-gcc-9.2/lib/gcc/arm-tizen-linux-gnueabi/9.2.0/../../../../arm-tizen-linux-gnueabi/bin/
ld: webview.cc:(.text+0x49a8): undefined reference to `LWE::WebContainer::ScrollTo(int, int)'
/home/swift/tizen-studio/tools/smart-build-interface/../arm-linux-gnueabi-gcc-9.2/lib/gcc/arm-tizen-linux-gnueabi/9.2.0/../../../../arm-tizen-linux-gnueabi/bin/
ld: webview.cc:(.text+0x4a64): undefined reference to `LWE::WebContainer::RemoveJavascriptInterface(std::__cxx11::basic_string<char, std::char_traits<char>,
std::allocator<char> > const&, std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > const&)'
/home/swift/tizen-studio/tools/smart-build-interface/../arm-linux-gnueabi-gcc-9.2/lib/gcc/arm-tizen-linux-gnueabi/9.2.0/../../../../arm-tizen-linux-gnueabi/bin/
ld: webview.cc:(.text+0x4b4c): undefined reference to `LWE::WebContainer::ScrollBy(int, int)'
/home/swift/tizen-studio/tools/smart-build-interface/../arm-linux-gnueabi-gcc-9.2/lib/gcc/arm-tizen-linux-gnueabi/9.2.0/../../../../arm-tizen-linux-gnueabi/bin/
ld: webview.cc:(.text+0x4bd4): undefined reference to `LWE::WebContainer::GetScrollX()'
/home/swift/tizen-studio/tools/smart-build-interface/../arm-linux-gnueabi-gcc-9.2/lib/gcc/arm-tizen-linux-gnueabi/9.2.0/../../../../arm-tizen-linux-gnueabi/bin/
ld: webview.cc:(.text+0x4c24): undefined reference to `LWE::WebContainer::GetScrollY()'
/home/swift/tizen-studio/tools/smart-build-interface/../arm-linux-gnueabi-gcc-9.2/lib/gcc/arm-tizen-linux-gnueabi/9.2.0/../../../../arm-tizen-linux-gnueabi/bin/
ld: ./Release//home/swift/Git/flutter/plugins/packages/webview_flutter/tizen/src/webview.o: in function
`WebView::HandleCookieMethodCall(flutter::MethodCall<flutter::EncodableValue> const&, std::unique_ptr<flutter::MethodResult<flutter::EncodableValue>,
std::default_delete<flutter::MethodResult<flutter::EncodableValue> > >)':
webview.cc:(.text+0x546c): undefined reference to `LWE::CookieManager::GetInstance()'
/home/swift/tizen-studio/tools/smart-build-interface/../arm-linux-gnueabi-gcc-9.2/lib/gcc/arm-tizen-linux-gnueabi/9.2.0/../../../../arm-tizen-linux-gnueabi/bin/
ld: webview.cc:(.text+0x5470): undefined reference to `LWE::CookieManager::ClearCookies()'
/home/swift/tizen-studio/tools/smart-build-interface/../arm-linux-gnueabi-gcc-9.2/lib/gcc/arm-tizen-linux-gnueabi/9.2.0/../../../../arm-tizen-linux-gnueabi/bin/
ld: ./Release//home/swift/Git/flutter/plugins/packages/webview_flutter/tizen/src/webview.o: in function
`WebView::DispatchKeyDownEvent(_Ecore_Event_Key*)::$_10::__invoke(void*)':
webview.cc:(.text+0x56ec): undefined reference to `LWE::WebContainer::DispatchKeyDownEvent(LWE::KeyValue)'
/home/swift/tizen-studio/tools/smart-build-interface/../arm-linux-gnueabi-gcc-9.2/lib/gcc/arm-tizen-linux-gnueabi/9.2.0/../../../../arm-tizen-linux-gnueabi/bin/
ld: webview.cc:(.text+0x56f8): undefined reference to `LWE::WebContainer::DispatchKeyPressEvent(LWE::KeyValue)'
/home/swift/tizen-studio/tools/smart-build-interface/../arm-linux-gnueabi-gcc-9.2/lib/gcc/arm-tizen-linux-gnueabi/9.2.0/../../../../arm-tizen-linux-gnueabi/bin/
ld: webview.cc:(.text+0x5704): undefined reference to `LWE::WebContainer::DispatchKeyUpEvent(LWE::KeyValue)'
/home/swift/tizen-studio/tools/smart-build-interface/../arm-linux-gnueabi-gcc-9.2/lib/gcc/arm-tizen-linux-gnueabi/9.2.0/../../../../arm-tizen-linux-gnueabi/bin/
ld: ./Release//home/swift/Git/flutter/plugins/packages/webview_flutter/tizen/src/webview.o: in function
`WebView::DispatchKeyDownEvent(_Ecore_Event_Key*)::$_12::__invoke(void*)':
webview.cc:(.text+0x5884): undefined reference to `LWE::WebContainer::DispatchKeyDownEvent(LWE::KeyValue)'
/home/swift/tizen-studio/tools/smart-build-interface/../arm-linux-gnueabi-gcc-9.2/lib/gcc/arm-tizen-linux-gnueabi/9.2.0/../../../../arm-tizen-linux-gnueabi/bin/
ld: webview.cc:(.text+0x588c): undefined reference to `LWE::WebContainer::DispatchKeyPressEvent(LWE::KeyValue)'
/home/swift/tizen-studio/tools/smart-build-interface/../arm-linux-gnueabi-gcc-9.2/lib/gcc/arm-tizen-linux-gnueabi/9.2.0/../../../../arm-tizen-linux-gnueabi/bin/
ld: ./Release//home/swift/Git/flutter/plugins/packages/webview_flutter/tizen/src/webview.o: in function
`WebView::DispatchKeyUpEvent(_Ecore_Event_Key*)::$_13::__invoke(void*)':
webview.cc:(.text+0x58bc): undefined reference to `LWE::WebContainer::DispatchKeyUpEvent(LWE::KeyValue)'
/home/swift/tizen-studio/tools/smart-build-interface/../arm-linux-gnueabi-gcc-9.2/lib/gcc/arm-tizen-linux-gnueabi/9.2.0/../../../../arm-tizen-linux-gnueabi/bin/
ld: ./Release//home/swift/Git/flutter/plugins/packages/webview_flutter/tizen/src/webview.o: in function `std::_Function_handler<void (LWE::WebContainer*,
std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > const&), WebView::WebView(flutter::PluginRegistrar*, int,
flutter::TextureRegistrar*, double, double, std::map<flutter::EncodableValue, flutter::EncodableValue, std::less<flutter::EncodableValue>,
std::allocator<std::pair<flutter::EncodableValue const, flutter::EncodableValue> > >&)::$_5>::_M_invoke(std::_Any_data const&, LWE::WebContainer*&&,
std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > const&)':
webview.cc:(.text+0x616c): undefined reference to `LWE::WebContainer::GetTitle[abi:cxx11]()'
/home/swift/tizen-studio/tools/smart-build-interface/../arm-linux-gnueabi-gcc-9.2/lib/gcc/arm-tizen-linux-gnueabi/9.2.0/../../../../arm-tizen-linux-gnueabi/bin/
ld: ./Release//home/swift/Git/flutter/plugins/packages/webview_flutter/tizen/src/webview.o: in function `std::_Function_handler<void (LWE::WebContainer*,
LWE::ResourceError), WebView::WebView(flutter::PluginRegistrar*, int, flutter::TextureRegistrar*, double, double, std::map<flutter::EncodableValue,
flutter::EncodableValue, std::less<flutter::EncodableValue>, std::allocator<std::pair<flutter::EncodableValue const, flutter::EncodableValue> >
>&)::$_7>::_M_invoke(std::_Any_data const&, LWE::WebContainer*&&, LWE::ResourceError&&)':
webview.cc:(.text+0x6c84): undefined reference to `LWE::ResourceError::GetErrorCode()'
/home/swift/tizen-studio/tools/smart-build-interface/../arm-linux-gnueabi-gcc-9.2/lib/gcc/arm-tizen-linux-gnueabi/9.2.0/../../../../arm-tizen-linux-gnueabi/bin/
ld: webview.cc:(.text+0x6db0): undefined reference to `LWE::ResourceError::GetDescription[abi:cxx11]()'
/home/swift/tizen-studio/tools/smart-build-interface/../arm-linux-gnueabi-gcc-9.2/lib/gcc/arm-tizen-linux-gnueabi/9.2.0/../../../../arm-tizen-linux-gnueabi/bin/
ld: webview.cc:(.text+0x6f48): undefined reference to `LWE::ResourceError::GetErrorCode()'
/home/swift/tizen-studio/tools/smart-build-interface/../arm-linux-gnueabi-gcc-9.2/lib/gcc/arm-tizen-linux-gnueabi/9.2.0/../../../../arm-tizen-linux-gnueabi/bin/
ld: webview.cc:(.text+0x745c): undefined reference to `LWE::ResourceError::GetUrl[abi:cxx11]()'
/home/swift/tizen-studio/tools/smart-build-interface/../arm-linux-gnueabi-gcc-9.2/lib/gcc/arm-tizen-linux-gnueabi/9.2.0/../../../../arm-tizen-linux-gnueabi/bin/
ld: ./Release//home/swift/Git/flutter/plugins/packages/webview_flutter/tizen/src/webview.o: in function
`NavigationRequestResult<flutter::EncodableValue>::SuccessInternal(flutter::EncodableValue const*)':
webview.cc:(.text._ZN23NavigationRequestResultIN7flutter14EncodableValueEE15SuccessInternalEPKS1_[_ZN23NavigationRequestResultIN7flutter14EncodableValueEE15Succ
essInternalEPKS1_]+0x38): undefined reference to `LWE::WebContainer::LoadURL(std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> >
const&)'
/home/swift/tizen-studio/tools/smart-build-interface/../arm-linux-gnueabi-gcc-9.2/lib/gcc/arm-tizen-linux-gnueabi/9.2.0/../../../../arm-tizen-linux-gnueabi/bin/
ld: ./Release//home/swift/Git/flutter/plugins/packages/webview_flutter/tizen/src/webview_factory.o: in function
`WebViewFactory::WebViewFactory(flutter::PluginRegistrar*, flutter::TextureRegistrar*)':
webview_factory.cc:(.text+0x37c): undefined reference to `LWE::LWE::Initialize(char const*, char const*, char const*)'
/home/swift/tizen-studio/tools/smart-build-interface/../arm-linux-gnueabi-gcc-9.2/lib/gcc/arm-tizen-linux-gnueabi/9.2.0/../../../../arm-tizen-linux-gnueabi/bin/
ld: ./Release//home/swift/Git/flutter/plugins/packages/webview_flutter/tizen/src/webview_factory.o: in function `WebViewFactory::Dispose()':
webview_factory.cc:(.text+0x7a8): undefined reference to `LWE::LWE::Finalize()'
clang++: error: linker command failed with exit code 1 (use -v to see invocation)
make[1]: *** [/home/swift/tizen-studio/tools/ide/resources/native/Build/makefile.mk:151: Release/libflutter_plugins.so] Error 1
make[1]: Leaving directory '/tmp/flutter_tools.TLGPTW/0'
make: *** [/home/swift/tizen-studio/tools/ide/resources/native/Build/makefile:27: app_build] Error 2
Total time: 00:00:13.895
Building a Tizen application in release mode...                    15.2s
Exception: The build failed.

Update) I think I didn't copy updated headers properly.

@bwikbs
Copy link
Member Author

bwikbs commented Jun 2, 2021

You included an armel binary in the lib/aarch64 directory.

Oh my god! 😱 SORRY!

@swift-kim
Copy link
Member

I couldn't get the example app to run on both TW3 and TM1.

On TM1 (running Tizen 6.0):

Syncing files to device Tizen TM1...                                94ms

Flutter run key commands.
r Hot reload. 🔥🔥🔥
R Hot restart.
h Repeat this help message.
d Detach (terminate "flutter run" but leave application running).
c Clear the screen
q Quit (terminate the application on the device).
An Observatory debugger and profiler on Tizen TM1 is available at: http://127.0.0.1:52851/xzplhbpvMd8=/

Flutter DevTools, a Flutter debugger and profiler, on Tizen TM1 is available at: http://127.0.0.1:9100?uri=http%3A%2F%2F127.0.0.1%3A52851%2FxzplhbpvMd8%3D%2F

💪 Running with sound null safety 💪
I/ConsoleMessage( 3549): flutter: _TizenWebViewState::didChangeDependencies()
I/ConsoleMessage( 3549): flutter: PlatformViewsServiceTizen::initTizenView [id:0] [onFocus:Closure: () => void]

══╡ EXCEPTION CAUGHT BY WIDGETS LIBRARY ╞═══════════════════════════════════════════════════════════
The following _CastError was thrown building FutureBuilder<WebViewController>(dirty, state:
_FutureBuilderState<WebViewController>#0902c):
Null check operator used on a null value

The relevant error-causing widget was:
  FutureBuilder<WebViewController>
  file:///home/swift/Git/plugins/packages/webview_flutter/example/lib/main.dart:298:12

When the exception was thrown, this was the stack:
#0      NavigationControls.build.<anonymous closure> (package:webview_flutter_tizen_example/main.dart:304:59)
#1      _FutureBuilderState.build (package:flutter/src/widgets/async.dart:773:55)
#2      StatefulElement.build (package:flutter/src/widgets/framework.dart:4612:27)
#3      ComponentElement.performRebuild (package:flutter/src/widgets/framework.dart:4495:15)
#4      StatefulElement.performRebuild (package:flutter/src/widgets/framework.dart:4667:11)
#5      Element.rebuild (package:flutter/src/widgets/framework.dart:4189:5)
#6      ComponentElement._firstBuild (package:flutter/src/widgets/framework.dart:4474:5)
#7      StatefulElement._firstBuild (package:flutter/src/widgets/framework.dart:4658:11)
#8      ComponentElement.mount (package:flutter/src/widgets/framework.dart:4469:5)
...     Normal element mounting (7 frames)
#15     Element.inflateWidget (package:flutter/src/widgets/framework.dart:3541:14)
#16     MultiChildRenderObjectElement.mount (package:flutter/src/widgets/framework.dart:6094:32)
...     Normal element mounting (19 frames)
#35     Element.inflateWidget (package:flutter/src/widgets/framework.dart:3541:14)
#36     MultiChildRenderObjectElement.mount (package:flutter/src/widgets/framework.dart:6094:32)
...     Normal element mounting (129 frames)
#165    Element.inflateWidget (package:flutter/src/widgets/framework.dart:3541:14)
#166    MultiChildRenderObjectElement.mount (package:flutter/src/widgets/framework.dart:6094:32)
...     Normal element mounting (238 frames)
#404    Element.inflateWidget (package:flutter/src/widgets/framework.dart:3541:14)
#405    MultiChildRenderObjectElement.mount (package:flutter/src/widgets/framework.dart:6094:32)
...     Normal element mounting (309 frames)
#714    Element.inflateWidget (package:flutter/src/widgets/framework.dart:3541:14)
#715    Element.updateChild (package:flutter/src/widgets/framework.dart:3306:18)
#716    RenderObjectToWidgetElement._rebuild (package:flutter/src/widgets/binding.dart:1182:16)
#717    RenderObjectToWidgetElement.mount (package:flutter/src/widgets/binding.dart:1153:5)
#718    RenderObjectToWidgetAdapter.attachToRenderTree.<anonymous closure> (package:flutter/src/widgets/binding.dart:1095:18)
#719    BuildOwner.buildScope (package:flutter/src/widgets/framework.dart:2647:19)
#720    RenderObjectToWidgetAdapter.attachToRenderTree (package:flutter/src/widgets/binding.dart:1094:13)
#721    WidgetsBinding.attachRootWidget (package:flutter/src/widgets/binding.dart:934:7)
#722    WidgetsBinding.scheduleAttachRootWidget.<anonymous closure> (package:flutter/src/widgets/binding.dart:915:7)
(elided 11 frames from class _RawReceivePortImpl, class _Timer, dart:async, and dart:async-patch)

════════════════════════════════════════════════════════════════════════════════════════════════════

Another exception was thrown: A RenderFlex overflowed by 99724 pixels on the right.
I/ConsoleMessage( 3549): flutter: WebView is loading (progress : 10%)
I/ConsoleMessage( 3549): flutter: Page started loading: https://www.google.com
I/ConsoleMessage( 3549): flutter: WebView is loading (progress : 0%)
I/ConsoleMessage( 3549): flutter: Page finished loading: https://www.google.com

0xb7eef548_0

It sometimes says it cannot open the page even though the device is connected to a Wi-Fi network,

0xb7f6f550_0

and it sometimes cannot render frames properly (flickering + more than half of the page is drawn black).

On TW3 (running Tizen 6.0):

Syncing files to device Tizen TW3...                                87ms

Flutter run key commands.
r Hot reload. 🔥🔥🔥
R Hot restart.
h Repeat this help message.
d Detach (terminate "flutter run" but leave application running).
c Clear the screen
q Quit (terminate the application on the device).
An Observatory debugger and profiler on Tizen TW3 is available at: http://127.0.0.1:53040/6po0ISF2JB0=/

Flutter DevTools, a Flutter debugger and profiler, on Tizen TW3 is available at: http://127.0.0.1:9100?uri=http%3A%2F%2F127.0.0.1%3A53040%2F6po0ISF2JB0%3D%2F

💪 Running with sound null safety 💪
I/ConsoleMessage( 4031): flutter: _TizenWebViewState::didChangeDependencies()
I/ConsoleMessage( 4031): flutter: PlatformViewsServiceTizen::initTizenView [id:0] [onFocus:Closure: () => void]

══╡ EXCEPTION CAUGHT BY WIDGETS LIBRARY ╞═══════════════════════════════════════════════════════════
The following _CastError was thrown building FutureBuilder<WebViewController>(dirty, state:
_FutureBuilderState<WebViewController>#dd4cb):
Null check operator used on a null value

The relevant error-causing widget was:
  FutureBuilder<WebViewController>
  file:///home/swift/Git/plugins/packages/webview_flutter/example/lib/main.dart:298:12

When the exception was thrown, this was the stack:
#0      NavigationControls.build.<anonymous closure> (package:webview_flutter_tizen_example/main.dart:304:59)
#1      _FutureBuilderState.build (package:flutter/src/widgets/async.dart:773:55)
#2      StatefulElement.build (package:flutter/src/widgets/framework.dart:4612:27)
#3      ComponentElement.performRebuild (package:flutter/src/widgets/framework.dart:4495:15)
#4      StatefulElement.performRebuild (package:flutter/src/widgets/framework.dart:4667:11)
#5      Element.rebuild (package:flutter/src/widgets/framework.dart:4189:5)
#6      ComponentElement._firstBuild (package:flutter/src/widgets/framework.dart:4474:5)
#7      StatefulElement._firstBuild (package:flutter/src/widgets/framework.dart:4658:11)
#8      ComponentElement.mount (package:flutter/src/widgets/framework.dart:4469:5)
...     Normal element mounting (7 frames)
#15     Element.inflateWidget (package:flutter/src/widgets/framework.dart:3541:14)
#16     MultiChildRenderObjectElement.mount (package:flutter/src/widgets/framework.dart:6094:32)
...     Normal element mounting (19 frames)
#35     Element.inflateWidget (package:flutter/src/widgets/framework.dart:3541:14)
#36     MultiChildRenderObjectElement.mount (package:flutter/src/widgets/framework.dart:6094:32)
...     Normal element mounting (129 frames)
#165    Element.inflateWidget (package:flutter/src/widgets/framework.dart:3541:14)
#166    MultiChildRenderObjectElement.mount (package:flutter/src/widgets/framework.dart:6094:32)
...     Normal element mounting (238 frames)
#404    Element.inflateWidget (package:flutter/src/widgets/framework.dart:3541:14)
#405    MultiChildRenderObjectElement.mount (package:flutter/src/widgets/framework.dart:6094:32)
...     Normal element mounting (309 frames)
#714    Element.inflateWidget (package:flutter/src/widgets/framework.dart:3541:14)
#715    Element.updateChild (package:flutter/src/widgets/framework.dart:3306:18)
#716    RenderObjectToWidgetElement._rebuild (package:flutter/src/widgets/binding.dart:1182:16)
#717    RenderObjectToWidgetElement.mount (package:flutter/src/widgets/binding.dart:1153:5)
#718    RenderObjectToWidgetAdapter.attachToRenderTree.<anonymous closure> (package:flutter/src/widgets/binding.dart:1095:18)
#719    BuildOwner.buildScope (package:flutter/src/widgets/framework.dart:2647:19)
#720    RenderObjectToWidgetAdapter.attachToRenderTree (package:flutter/src/widgets/binding.dart:1094:13)
#721    WidgetsBinding.attachRootWidget (package:flutter/src/widgets/binding.dart:934:7)
#722    WidgetsBinding.scheduleAttachRootWidget.<anonymous closure> (package:flutter/src/widgets/binding.dart:915:7)
(elided 11 frames from class _RawReceivePortImpl, class _Timer, dart:async, and dart:async-patch)

════════════════════════════════════════════════════════════════════════════════════════════════════
E/ConsoleMessage( 4031): ==>[WARN] (Runner.dll) [EGL] egl/src/mali_egl_display.c:1994 eglInitialize MALI driver version is [U:r21p0-01rel0 K:r21p0-01rel0(GPL)] commit [c25c9a00c5a21e96ab8aede3b0b166d0ae08369c]

Another exception was thrown: A RenderFlex overflowed by 99753 pixels on the right.
I/ConsoleMessage( 4031): flutter: WebView is loading (progress : 10%)
I/ConsoleMessage( 4031): flutter: Page started loading: https://www.google.com
E/ConsoleMessage( 4031): ==>[ERROR] (Runner.dll) [GLES] gles/src/texture/mali_gles_texture_helpers.c:1001 gles_texturep_tex_parameteri_input_param_validation 0x1:GLES_ERROR_INVALID_ENUM in glTexParameteri [<param> is not an accepted value]
E/ConsoleMessage( 4031): ==>[ERROR] (Runner.dll) [GLES] gles/src/texture/mali_gles_texture_helpers.c:1001 gles_texturep_tex_parameteri_input_param_validation 0x1:GLES_ERROR_INVALID_ENUM in glTexParameteri [<param> is not an accepted value]
I/ConsoleMessage( 4031): flutter: WebView is loading (progress : 55%)
I/ConsoleMessage( 4031): flutter: WebView is loading (progress : 0%)
E/ConsoleMessage( 4031): ==>[ERROR] (Runner.dll) [GLES] gles/src/texture/mali_gles_texture_api.c:953 gles_texture_tex_sub_image_2d 0x3:GLES_ERROR_INVALID_OPERATION in glTexSubImage2D [texture image does not exist]
E/ConsoleMessage( 4031): ==>[ERROR] (Runner.dll) [GLES] gles/src/texture/mali_gles_texture_api.c:953 gles_texture_tex_sub_image_2d 0x3:GLES_ERROR_INVALID_OPERATION in glTexSubImage2D [texture image does not exist]
E/ConsoleMessage( 4031): ==>[ERROR] (Runner.dll) [GLES] gles/src/texture/mali_gles_texture_api.c:953 gles_texture_tex_sub_image_2d 0x3:GLES_ERROR_INVALID_OPERATION in glTexSubImage2D [texture image does not exist]
E/ConsoleMessage( 4031): ==>[ERROR] (Runner.dll) [GLES] gles/src/texture/mali_gles_texture_api.c:953 gles_texture_tex_sub_image_2d 0x3:GLES_ERROR_INVALID_OPERATION in glTexSubImage2D [texture image does not exist]
E/ConsoleMessage( 4031): ==>[ERROR] (Runner.dll) [GLES] gles/src/texture/mali_gles_texture_api.c:953 gles_texture_tex_sub_image_2d 0x3:GLES_ERROR_INVALID_OPERATION in glTexSubImage2D [texture image does not exist]
E/ConsoleMessage( 4031): ==>[ERROR] (Runner.dll) [GLES] gles/src/texture/mali_gles_texture_api.c:953 gles_texture_tex_sub_image_2d 0x3:GLES_ERROR_INVALID_OPERATION in glTexSubImage2D [texture image does not exist]
I/ConsoleMessage( 4031): flutter: Page finished loading: https://www.google.com
E/ConsoleMessage( 4031): ==>[ERROR] (Runner.dll) [GLES] gles/src/texture/mali_gles_texture_api.c:953 gles_texture_tex_sub_image_2d 0x3:GLES_ERROR_INVALID_OPERATION in glTexSubImage2D [texture image does not exist]
E/ConsoleMessage( 4031): ==>[ERROR] (Runner.dll) [GLES] gles/src/texture/mali_gles_texture_api.c:953 gles_texture_tex_sub_image_2d 0x3:GLES_ERROR_INVALID_OPERATION in glTexSubImage2D [texture image does not exist]
E/ConsoleMessage( 4031): ==>[ERROR] (Runner.dll) [GLES] gles/src/texture/mali_gles_texture_api.c:953 gles_texture_tex_sub_image_2d 0x3:GLES_ERROR_INVALID_OPERATION in glTexSubImage2D [texture image does not exist]
E/ConsoleMessage( 4031): ==>[ERROR] (Runner.dll) [GLES] gles/src/texture/mali_gles_texture_api.c:953 gles_texture_tex_sub_image_2d 0x3:GLES_ERROR_INVALID_OPERATION in glTexSubImage2D [texture image does not exist]
E/ConsoleMessage( 4031): ==>[ERROR] (Runner.dll) [GLES] gles/src/texture/mali_gles_texture_api.c:953 gles_texture_tex_sub_image_2d 0x3:GLES_ERROR_INVALID_OPERATION in glTexSubImage2D [texture image does not exist]
...

In this case the webpage seems to be rendered, but I can't browse the page properly because majority of the frames are skipped due to the above error.

@bwikbs
Copy link
Member Author

bwikbs commented Jun 2, 2021

Thanks for letting me know. I'll check it out asap!

* Update lightweightwebengine binary (aarch64/armel, tizen 5.5)
* Introduce buffer pool

Signed-off-by: MuHong Byun <[email protected]>
@bwikbs
Copy link
Member Author

bwikbs commented Jun 3, 2021

Now, flicking issue is gone. Binaries have the proper version and architecture.

TW3 still seems to have a problem, but it doesn't seem to be a webview problem. We need to check the embedder part.

@bbrto21
Copy link
Contributor

bbrto21 commented Jun 3, 2021

Now, flicking issue is gone. Binaries have the proper version and architecture.

Could you share a guide to testing the flicking issue?

@bwikbs
Copy link
Member Author

bwikbs commented Jun 3, 2021

Could you share a guide to testing the flicking issue?

Before this, everything is flicking. My test URL is https://css-tricks.com/examples/Circulate/

@bbrto21
Copy link
Contributor

bbrto21 commented Jun 3, 2021

Could you share a guide to testing the flicking issue?

Before this, everything is flicking. My test URL is https://css-tricks.com/examples/Circulate/

Thanks! I confirmed that flickering issue has been resolved on TM1

@bwikbs
Copy link
Member Author

bwikbs commented Jun 3, 2021

TW3 still seems to have a problem, but it doesn't seem to be a webview problem. We need to check the embedder part.

I just realized that webview is not checked in evasgl backend.(It's not even a quick fix!)
It's perfectly working at R840(TW3) with following command.
flutter-tizen build tpk --device-profile mobile && flutter-tizen install ./build/tizen/tpk/org.tizen.webview_flutter_tizen_example-1.0.0.tpk

Copy link
Contributor

@bbrto21 bbrto21 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bbrto21 bbrto21 merged commit 9905fa8 into flutter-tizen:master Jun 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants