[webview_flutter_dev] Change webview interface && embedding lwe.so file #15

bwikbs · 2021-01-06T06:45:55Z

Now, we can run webview test app without any preparations

Just run flutter-tizen run at example.

* temporal soluation Signed-off-by: MuHong Byun <[email protected]>

packages/webview_flutter/tizen/project_def.prop

bbrto21 · 2021-01-06T07:18:31Z

packages/webview_flutter/tizen/src/webview.cc

@@ -438,23 +448,16 @@ void WebView::InitWebView() {
  }
  float scaleFactor = 1;


There is some routine to calculate the scale factor on the engine side, Should it be shared by the engine?
This is just my curiosity.

I guess.. we should use engine's value. we need to modify platform view's interface for that.

seungsoo47 · 2021-01-06T07:46:38Z

The liblightweight-web-engine.mobile.so file is on example directory. However, I think this library has to be located on plugin side. How do you think of this? And how do you think of removing the word "mobile" in the name?

bwikbs · 2021-01-06T08:14:01Z

Actually. so file is located on both sides.(plugin & example). Only reason it exists in the example side is purely for the convenience of execution. So it seems like the problem of naming is not big deal at this moment I guess. we should think about how to distribute lwe first.

bwikbs · 2021-01-06T23:57:45Z

Here are the results of running this for each profile.

TW3 -> There is no big problem.
TV -> We can't load so of apps, crash occurs after short running, re-compilation required
TM1 -> The screen flickers and is very unstable.
FHUB -> Prertty much the same with TM1

seungsoo47

LGTM

…le (flutter-tizen#15) * temporal soluation Signed-off-by: MuHong Byun <[email protected]>

* This PR is created from the PR below: 2bfc038 [webview_flutter] Update README and pubspec (flutter-tizen#53) bdd6a15 [webview_flutter] Enable intergation test (flutter-tizen#52) 18da2a6 [webview_flutter] Update code by flutter version-up (flutter-tizen#49) 1b6eeed [webview_flutter] Handle CompositionEvent (flutter-tizen#47) 791511e [webview_flutter] Optimize tbm allocation (flutter-tizen#42) 7059ce2 [webview_flutter] Add cookie and scroll APIs (flutter-tizen#40) c5a8930 Add some APIs (flutter-tizen#37) 3feae1d [webview_flutter] Add NavigationDelegate and onWebResourceError (flutter-tizen#36) 42b63f8 [webview_flutter] Add removeJavascriptChannels API and Callbacks (flutter-tizen#31) 749930e [webview_flutter] Update LWE (flutter-tizen#28) 9e26386 [webview_flutter] Implement addJavascriptChannels() (flutter-tizen#27) 6a34ae0 [webview_flutter] Update LWE (flutter-tizen#26) a438093 [webview_flutter] Add evaluateJavascript() function (flutter-tizen#25) 0d2c271 [webview_flutter] Update webview to be focused (flutter-tizen#19) b02b245 Enable IMF on Webview (flutter-tizen#17) 571fa4a [webview_flutter_dev] Change webview interface && embedding lwe.so file (flutter-tizen#15) 3413964 [webview_flutter_dev] Enable gl compositor at LWE (flutter-tizen#14) e988cf0 Change method name's first letter (flutter-tizen#13) cb8ee9b Handle key events for tizen webview (flutter-tizen#11) 44987de [webview_flutter] Add webview_flutter initial package (flutter-tizen#7) Co-authored-by: MuHong Byun <[email protected]> Co-authored-by: Seungsoo Lee <[email protected]>

* [webview_flutter] Add webview_flutter_tizen package * This PR is created from the PR below: 2bfc038 [webview_flutter] Update README and pubspec (#53) bdd6a15 [webview_flutter] Enable intergation test (#52) 18da2a6 [webview_flutter] Update code by flutter version-up (#49) 1b6eeed [webview_flutter] Handle CompositionEvent (#47) 791511e [webview_flutter] Optimize tbm allocation (#42) 7059ce2 [webview_flutter] Add cookie and scroll APIs (#40) c5a8930 Add some APIs (#37) 3feae1d [webview_flutter] Add NavigationDelegate and onWebResourceError (#36) 42b63f8 [webview_flutter] Add removeJavascriptChannels API and Callbacks (#31) 749930e [webview_flutter] Update LWE (#28) 9e26386 [webview_flutter] Implement addJavascriptChannels() (#27) 6a34ae0 [webview_flutter] Update LWE (#26) a438093 [webview_flutter] Add evaluateJavascript() function (#25) 0d2c271 [webview_flutter] Update webview to be focused (#19) b02b245 Enable IMF on Webview (#17) 571fa4a [webview_flutter_dev] Change webview interface && embedding lwe.so file (#15) 3413964 [webview_flutter_dev] Enable gl compositor at LWE (#14) e988cf0 Change method name's first letter (#13) cb8ee9b Handle key events for tizen webview (#11) 44987de [webview_flutter] Add webview_flutter initial package (#7) Co-authored-by: MuHong Byun <[email protected]> Co-authored-by: Seungsoo Lee <[email protected]> * [webview_flutter] Update manifest file and remove unnecessary code * Replace tabs to spaces in the manifest file * Fix broken READEME.md * Remove unnecessary code * [webview_flutter] Update initailization code * In accordance with the guideline, I have updated the initialization code. * Fix integration test bug * Fix bugs for data files and key events * Data files will be created in application's private area. * Key event including Shift key value will be handled properly. * Apply latest flutter-tizen * Because the latest flutter-tizen supports automatic copy function of plugin-dependent libraries, I updated a prof file and removed a library using in this plugin. Co-authored-by: MuHong Byun <[email protected]>

[webview_flutter_dev] Change webview interface && embedding lwe.so file

a90ddfe

* temporal soluation Signed-off-by: MuHong Byun <[email protected]>

bwikbs requested review from seungsoo47 and bbrto21 January 6, 2021 06:45

bbrto21 reviewed Jan 6, 2021

View reviewed changes

packages/webview_flutter/tizen/project_def.prop Show resolved Hide resolved

bbrto21 reviewed Jan 6, 2021

View reviewed changes

bbrto21 approved these changes Jan 6, 2021

View reviewed changes

seungsoo47 approved these changes Jan 7, 2021

View reviewed changes

seungsoo47 merged commit 0076f80 into flutter-tizen:webview_devel Jan 7, 2021

bwikbs added a commit to bwikbs/plugins that referenced this pull request Jan 21, 2021

[webview_flutter_dev] Change webview interface && embedding lwe.so fi…

db903c7

…le (flutter-tizen#15) * temporal soluation Signed-off-by: MuHong Byun <[email protected]>

bwikbs added a commit to bwikbs/plugins that referenced this pull request Jan 27, 2021

[webview_flutter_dev] Change webview interface && embedding lwe.so fi…

571fa4a

…le (flutter-tizen#15) * temporal soluation Signed-off-by: MuHong Byun <[email protected]>

bwikbs added a commit to bwikbs/plugins that referenced this pull request Mar 29, 2021

[webview_flutter_dev] Change webview interface && embedding lwe.so fi…

fcd13f1

…le (flutter-tizen#15) * temporal soluation Signed-off-by: MuHong Byun <[email protected]>

seungsoo47 mentioned this pull request Mar 29, 2021

[webview_flutter] Add webview_flutter_tizen package #54

Merged

xiaowei-guan mentioned this pull request Nov 2, 2021

[VideoPlayer]Null check operator used on a null value #261

Closed

xiaowei-guan mentioned this pull request Feb 13, 2023

[flutter_webrtc] App crashes with SIGSEGV when closing #524

Closed

AMarozzi mentioned this pull request Jul 11, 2024

video_player_avplay crash #701

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[webview_flutter_dev] Change webview interface && embedding lwe.so file #15

[webview_flutter_dev] Change webview interface && embedding lwe.so file #15

bwikbs commented Jan 6, 2021

bbrto21 Jan 6, 2021

bwikbs Jan 6, 2021

seungsoo47 commented Jan 6, 2021

bwikbs commented Jan 6, 2021

bwikbs commented Jan 6, 2021

seungsoo47 left a comment

		@@ -438,23 +448,16 @@ void WebView::InitWebView() {
		}
		float scaleFactor = 1;

[webview_flutter_dev] Change webview interface && embedding lwe.so file #15

[webview_flutter_dev] Change webview interface && embedding lwe.so file #15

Conversation

bwikbs commented Jan 6, 2021

bbrto21 Jan 6, 2021

Choose a reason for hiding this comment

bwikbs Jan 6, 2021

Choose a reason for hiding this comment

seungsoo47 commented Jan 6, 2021

bwikbs commented Jan 6, 2021

bwikbs commented Jan 6, 2021

seungsoo47 left a comment

Choose a reason for hiding this comment