Skip to content

Test on multiple device profile emulators #238

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

HakkyuKim
Copy link
Contributor

@HakkyuKim HakkyuKim commented Oct 7, 2021

I've tested locally on my machine, I'll mark it as "ready for review" when I've tested on the internal server.

Test passed on internal server: https://github.com/flutter-tizen/plugins/pull/228/checks?check_run_id=3834753312.

@github-actions github-actions bot added the tools label Oct 7, 2021
@swift-kim
Copy link
Member

Tizen devices (including real devices) are basically all ephemeral. Why don't you use the term "emulator" instead of "ephemeral device"?

@HakkyuKim
Copy link
Contributor Author

@swift-kim
In the context of the tool, I defined the term "ephemeral" as targets(real devices and emulators) that are created and deleted by to tool, I admit it doesn't make sense for real devices so I could have used the term ephemeral-emulators. If I use the term "emulator", it could mean choosing between a connected real device and a running emulator process. Does ephemeral-emulators sound better?

Tizen devices (including real devices) are basically all ephemeral.

I did not understand this part. Could you explain in detail?

@swift-kim
Copy link
Member

The Flutter SDK (flutter_tools) defines an ephemeral device as a device that can be connected and disconnect to the host. For example, Android devices are ephemeral because the host needs to connect to the devices before operating on them, and a Windows device is non-ephemeral because the device itself is the host and can never disconnect. Thus, in terms of this definition, all Tizen devices are ephemeral. Do you really need to distinguish between emulator instances that are created by the tester tool on the fly and not created by it?

@HakkyuKim
Copy link
Contributor Author

Thanks for the info. In that definition, I see that the current use of the term doesn't make sense. I do need an option that tests on emulators which are created and deleted by the tool on the fly instead of testing on any running emulator instances. I could simply use the phrase --generate-emulators for the option.

@swift-kim
Copy link
Member

@HakkyuKim That sounds good. I just wanted to make it clear. Thanks.

@HakkyuKim HakkyuKim changed the title Test on multiple ephemeral profile targets Test on multiple device profile emulators Oct 8, 2021
@HakkyuKim HakkyuKim mentioned this pull request Oct 8, 2021
@HakkyuKim HakkyuKim force-pushed the test-on-multiple-ephemeral-profile-targets branch from 28e8a98 to 407acbe Compare October 8, 2021 04:12
@HakkyuKim HakkyuKim marked this pull request as ready for review October 8, 2021 04:41
Copy link
Member

@bwikbs bwikbs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's pretty cool! 👍

@HakkyuKim HakkyuKim merged commit 18ee714 into flutter-tizen:master Oct 12, 2021
@HakkyuKim HakkyuKim deleted the test-on-multiple-ephemeral-profile-targets branch December 21, 2021 04:34
bwikbs pushed a commit to bwikbs/plugins that referenced this pull request Mar 26, 2022
* Test on multiple ephemeral profile targets

* Rename the option to --generate-emulators

* Exclude some tests

* Add issue link in recipe file
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants