[flutter_splash_tizen] Initial implementation #266

JRazek · 2021-11-05T10:04:40Z

Issue #151
Adds support for native splash as a flutter package.

pkosko · 2021-11-05T11:02:54Z

packages/flutter_splash_tizen/example/pubspec.yaml

+  uses-material-design: true
+
+flutter_splash_tizen:
+  image: assets/test.png


no new line at the end of file

one more comment - I assume that the example application is after adding a splash file with flutter-tizen pub run flutter_splash_tizen:create because related line is added to tizen-manifest.xml. But file assets/test.png does not exist, so removing splash and re-adding it again will probably fail - please check it.

I am not also sure if packages/flutter_splash_tizen/example/tizen/shared/res/test.png file will work as a splash screen, as the tizen-manifest file uses: assets/test.png.

pkosko · 2021-11-05T11:05:06Z

packages/flutter_splash_tizen/example/lib/main.dart

+    // Platform messages may fail, so we use a try/catch PlatformException.
+    // We also handle the message potentially returning null.
+    try {
+      platformVersion =


is the platformVersion really a part of splash plugin? or is it just leftover after some base for development?

pkosko · 2021-11-05T11:08:28Z

packages/flutter_splash_tizen/pubspec.yaml

+dev_dependencies:
+  flutter_test:
+    sdk: flutter
+  flutter_lints: ^1.0.0


new line missing at the end of file

pkosko · 2021-11-05T11:08:50Z

packages/flutter_splash_tizen/test/flutter_splash_tizen_test.dart

+    channel.setMockMethodCallHandler(null);
+  });
+
+  test('getPlatformVersion', () async {


are these tests related to splash screen?

pkosko · 2021-11-05T11:09:10Z

packages/flutter_splash_tizen/lib/flutter_splash_tizen.dart

+import 'package:flutter/services.dart';
+
+class FlutterNativeSplashTizen {
+  static const MethodChannel _channel =


is it related to splash screen?

pkosko · 2021-11-05T11:16:56Z

packages/flutter_splash_tizen/bin/create.dart

+import 'package:xml/xml.dart';
+
+void main() {
+  var doc = loadYamlFileSync("pubspec.yaml")?['flutter_splash_tizen'];


if I understand correctly, current flow supports only adding a file once, then file added to yaml will be copied to tizen-manifest. What about changing a file mentioned in yaml during the development? Shouldn't we consider a scenario that a file is added to manifest file everytime when application is built which means that the file used in tizen manifest will be kept in sync with file mentioned in pubspec.yaml file?

@swift-kim could you please share your opinion regarding this comment? Should we set splash screen 'on demand' only, or rather do it automatically on every build?

I think it's better to sync automatically every build if possible. By the way, is there a way to run this package every build?
Should we add this feature to flutter-tizen tool?

doc can be null. please check it.

@pkosko You can just follow flutter_native_splash's way. So manually running the pub run command every time the attributes are changed should just be enough.

pkosko · 2021-11-05T11:22:49Z

packages/flutter_splash_tizen/example/pubspec.yaml

+  uses-material-design: true
+
+flutter_splash_tizen:
+  image: assets/test.png


one more comment - I assume that the example application is after adding a splash file with flutter-tizen pub run flutter_splash_tizen:create because related line is added to tizen-manifest.xml. But file assets/test.png does not exist, so removing splash and re-adding it again will probably fail - please check it.

I am not also sure if packages/flutter_splash_tizen/example/tizen/shared/res/test.png file will work as a splash screen, as the tizen-manifest file uses: assets/test.png.

swift-kim · 2021-11-05T11:28:09Z

By the way this package is not a plugin. I need to make a decision on which repository this package should be placed in.

swift-kim · 2021-11-08T04:43:09Z

I discussed with @WonyoungChoi and we decided to keep this package in this repo for now. The decision may be changed in the future.

packages/flutter_splash_tizen/bin/create.dart

packages/flutter_splash_tizen/bin/file_utils.dart

WonyoungChoi · 2021-11-09T00:10:56Z

packages/flutter_splash_tizen/bin/remove.dart

+import 'package:xml/xml.dart';
+
+void main() {
+  var doc = loadYamlFileSync("pubspec.yaml")?['flutter_splash_tizen'];


unnecessary loading yaml file.

WonyoungChoi · 2021-11-09T00:18:44Z

packages/flutter_splash_tizen/bin/create.dart

+import 'package:xml/xml.dart';
+
+void main() {
+  var doc = loadYamlFileSync("pubspec.yaml")?['flutter_splash_tizen'];


doc can be null. please check it.

swift-kim

Issue:
A blank (black) screen is displayed before the first app frame is drawn and after the splash screen is displayed.

Additional work:

Adding to labeler (https://github.com/flutter-tizen/plugins/blob/master/.github/labeler.yml).
Adding to recipe (https://github.com/flutter-tizen/plugins/blob/master/tools/recipe.yaml).
Adding to README (https://github.com/flutter-tizen/plugins/blob/master/README.md).
Resolving any CI errors.

packages/flutter_splash_tizen/.metadata

packages/flutter_splash_tizen/CHANGELOG.md

packages/flutter_splash_tizen/pubspec.yaml

packages/flutter_splash_tizen/LICENSE

packages/flutter_splash_tizen/pubspec.yaml

packages/flutter_splash_tizen/example/tizen/tizen-manifest.xml

swift-kim · 2021-11-09T06:42:49Z

packages/flutter_splash_tizen/example/tizen/tizen-manifest.xml

@@ -0,0 +1,13 @@
+<?xml version="1.0" encoding="utf-8"?>
+<manifest package="com.example.flutter_splash_tizen_example" version="1.0.0" api-version="4.0" xmlns="http://tizen.org/ns/packages">
+    <profile name="wearable"/>


Does this package support TV as well?

Could you confirm whether splash screen is supported on TV devices or not? If not, you should mention the fact in the package's README.

@swift-kim As far as I see - it does not run on TV. It runs on mobile and on Wearable fine.

Will this work for that?

Package has been tested on Mobile 6.0, Wearable 6.0 and IoT Headed 6.5 platform.

.github/workflows/integration_test.yml

HakkyuKim · 2021-11-10T08:07:10Z

The CI will pass when you rebase to master branch.

WonyoungChoi · 2021-11-17T05:21:16Z

packages/flutter_splash_tizen/bin/remove.dart

+  String tizenManifestPath = "tizen/tizen-manifest.xml";
+
+  XmlDocument? tizenManifest = loadXMLFileSync(tizenManifestPath);
+  if (tizenManifest == null) {
+    throw const FormatException("could not read tizen-manifext.xml!");
+  }


Unnecessary exporting the method loadXMLFileSync.

Suggested change

String tizenManifestPath = "tizen/tizen-manifest.xml";

XmlDocument? tizenManifest = loadXMLFileSync(tizenManifestPath);

if (tizenManifest == null) {

throw const FormatException("could not read tizen-manifext.xml!");

}

File tizenManifestFile = File("tizen/tizen-manifest.xml");

if (!file.existsSync()) {

throw const FormatException("could not read tizen-manifext.xml!");

}

XmlDocument? tizenManifest = XmlDocument.parse(tizenManifestFile.readAsStringSync());

swift-kim · 2021-11-17T12:29:13Z

Did you read all my comments in the above?

swift-kim · 2021-11-18T06:03:39Z

Hey. There are more comments.

swift-kim · 2021-11-26T15:23:51Z

~~Are you serious? Why are you publishing a package which isn't even merged?~~

Well, publishing cannot be undone. We can still review this PR until until it becomes mergeable. Any new changes will be published in the next release.

swift-kim · 2021-11-26T15:25:19Z

Issue:
A blank (black) screen is displayed before the first app frame is drawn and after the splash screen is displayed.

This issue needs a fix before this package can be merged.

bbrto21 · 2021-12-09T11:43:20Z

Issue:
A blank (black) screen is displayed before the first app frame is drawn and after the splash screen is displayed.

This issue needs a fix before this package can be merged.

~~I opened new PR to fix this issue.~~
~~@JRazek Could you check it using this PR?~~

bbrto21 · 2021-12-10T01:30:04Z

I opened new PR to fix this issue. @JRazek Could you check it using this PR?

There's still a blank screen between the splash image and the first frame :(

JRazek added 2 commits November 5, 2021 11:01

flutter tizen splash

0a3c42e

img change

0f4ad8a

github-actions bot added the needs-publishing The package should be published after merge label Nov 5, 2021

pkosko requested a review from a team November 5, 2021 10:36

JRazek changed the title ~~flutter splash for tizen~~ flutter splash for tizen issue #151 Nov 5, 2021

JRazek changed the title ~~flutter splash for tizen issue #151~~ flutter splash for tizen Nov 5, 2021

JRazek added 2 commits November 5, 2021 11:48

license, changelog

abc30f7

cleanup

065e874

pkosko requested changes Nov 5, 2021

View reviewed changes

minimal main, new line at the end of the file

1672142

JRazek added 2 commits November 5, 2021 13:18

more cleanup

5520b56

example path fix

1ac69b2

JRazek added 6 commits November 8, 2021 12:27

main fixes

4620b31

flag fixes

0ee9340

flag fixes

2f6303c

flag fixes

5917fce

flag fixes

0f73916

flag fixes

07f43b3

WonyoungChoi reviewed Nov 9, 2021

View reviewed changes

packages/flutter_splash_tizen/bin/create.dart Outdated Show resolved Hide resolved

WonyoungChoi reviewed Nov 9, 2021

View reviewed changes

WonyoungChoi requested changes Nov 9, 2021

View reviewed changes

swift-kim requested changes Nov 9, 2021

View reviewed changes

JRazek added 5 commits November 9, 2021 08:27

suggested fixes and cleanups

b3a41f7

version

0aa13d9

homepage, repository

02e6a45

tv info removal

898757b

tizen-manifest cleanup

0b43e66

swift-kim reviewed Nov 10, 2021

View reviewed changes

.github/workflows/integration_test.yml Outdated Show resolved Hide resolved

JRazek added 5 commits November 10, 2021 10:30

integration tests comments

bbd104d

readme supported platforms

e64f750

dart format

b3e8736

analyze

7794d00

curly brackets and key widget constructor

ce20502

WonyoungChoi reviewed Nov 17, 2021

View reviewed changes

JRazek added 2 commits November 17, 2021 12:35

formating, consts

3f1f7bb

formating, consts

73a9641

readme, labeler

718934e

github-actions bot added the tools label Nov 17, 2021

JRazek closed this Nov 17, 2021

JRazek reopened this Nov 17, 2021

JRazek requested review from pkosko and WonyoungChoi November 17, 2021 13:48

JRazek added 3 commits November 26, 2021 16:00

not a package, formatting in pubspec

9a3a0d3

published

7973e7b

readme wasnt added in the first push

18278a6

swift-kim changed the title ~~flutter splash for tizen~~ [flutter_splash_tizen] Initial implementation Dec 3, 2021

bbrto21 mentioned this pull request Dec 13, 2021

Blank screen is displayed when launching app on Evas GL flutter-tizen/engine#222

Closed

swift-kim removed needs-publishing The package should be published after merge tools labels Jun 7, 2022

swift-kim closed this Sep 15, 2022

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[flutter_splash_tizen] Initial implementation #266

[flutter_splash_tizen] Initial implementation #266

JRazek commented Nov 5, 2021 •

edited

Loading

pkosko Nov 5, 2021

pkosko Nov 5, 2021

pkosko Nov 5, 2021

pkosko Nov 5, 2021

pkosko Nov 5, 2021

pkosko Nov 5, 2021

pkosko Nov 5, 2021

pkosko Nov 8, 2021

WonyoungChoi Nov 9, 2021

WonyoungChoi Nov 9, 2021

swift-kim Nov 9, 2021

pkosko Nov 5, 2021

swift-kim commented Nov 5, 2021

swift-kim commented Nov 8, 2021

WonyoungChoi Nov 9, 2021

WonyoungChoi Nov 9, 2021

swift-kim left a comment

swift-kim Nov 9, 2021

swift-kim Nov 10, 2021

JRazek Nov 10, 2021

JRazek Nov 26, 2021

HakkyuKim commented Nov 10, 2021

WonyoungChoi Nov 17, 2021 •

edited

Loading

swift-kim commented Nov 17, 2021

swift-kim commented Nov 18, 2021

swift-kim commented Nov 26, 2021 •

edited

Loading

swift-kim commented Nov 26, 2021

bbrto21 commented Dec 9, 2021 •

edited

Loading

bbrto21 commented Dec 10, 2021

[flutter_splash_tizen] Initial implementation #266

[flutter_splash_tizen] Initial implementation #266

Conversation

JRazek commented Nov 5, 2021 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

swift-kim commented Nov 5, 2021

swift-kim commented Nov 8, 2021

Choose a reason for hiding this comment

Choose a reason for hiding this comment

swift-kim left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

HakkyuKim commented Nov 10, 2021

WonyoungChoi Nov 17, 2021 • edited Loading

Choose a reason for hiding this comment

swift-kim commented Nov 17, 2021

swift-kim commented Nov 18, 2021

swift-kim commented Nov 26, 2021 • edited Loading

swift-kim commented Nov 26, 2021

bbrto21 commented Dec 9, 2021 • edited Loading

bbrto21 commented Dec 10, 2021

JRazek commented Nov 5, 2021 •

edited

Loading

WonyoungChoi Nov 17, 2021 •

edited

Loading

swift-kim commented Nov 26, 2021 •

edited

Loading

bbrto21 commented Dec 9, 2021 •

edited

Loading