[image_picker] Refactor the C++ code #353
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of the code refactoring project.
image_picker_tizen_plugin.cc
PermissionManager
as a replacement forCheckPermissionAndPickContent
.CheckPermission
andRequestPermssion
.RequestPermssion
is a blocking method.CheckPermission
method is not used by this package but is for use by other packages.PermissionStatus
andPermissionResult
respectively.kAllow
orkAllowForever
when compiled for TV.GetValueFromEncodableMap
template function to process method call arguments.SetContentMimeType
and letPickContent
takemime_type
as an argument.SendResultWithSuccess
/SendResultWithError
→SendResult
/SendErrorResult
image_resize.cc
Resize
and move many of its parts to individual methodsDecodeImage
,TransformImage
, andEncodeImage
as appropriate. For example, the decode handle is created byDecodeImage
but notResize
.IsValidQuality
.uint32_t
instead ofunsigned int
.SetSize
in the definition.image_util_decode_set_colorspace
.