-
Notifications
You must be signed in to change notification settings - Fork 51
[webview_flutter] Refactor the C++ code #383
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[webview_flutter] Refactor the C++ code #383
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall, I think it's good.
@seungsoo47 @bwikbs @JSUYA @Swanseo0 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I agree with the overall direction. I'm happy with this refactoring.
Thanks. 👍
84f34de
to
e457f49
Compare
Part of the code refactoring project.
BufferUnit
andBufferPool
:BufferUnit::Index
.BufferUnit::IsUsed
andBufferUnit::GpuBuffer
).WebView
:params
(constructor argument) toEncodableValue
to reuse theGetValueFromEncodableMap
function.RequestErrorType
toResourceErrorType
.NeedsSwBackend
toIsRunningOnEmulator
.texture_variant_
a unique pointer.HandleMethodCall
always send a result. (Fixes ImproveHandleMethodCall
method not to return without sending a result. #376.)DispatchKeyDownEvent
andDispatchKeyUpEvent
becauseHidePanel
is no longer used."Select"
has been added toKeyNameToKeyValue
withKeyValue::EnterKey
as a return value.WebViewFactory
:textureRegistrar
from constructor arguments. It can be taken fromregistrar
.GetAppDataPath
as a function.Other changes not listed in the above are style and readability fixes that are quite straightforward.