Skip to content

Add mp3 test audio file #177

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jan 29, 2022
Merged

Add mp3 test audio file #177

merged 2 commits into from
Jan 29, 2022

Conversation

jmagman
Copy link
Member

@jmagman jmagman commented Jan 28, 2022

flutter/plugins#4639 added support for the video_player plugin to play mp3s. Add an mp3 test file to be used by the plugin tests, similar to the existing mp4 test files like bee.mp4

mp3 is of a rooster: https://pixabay.com/sound-effects/rooster-crowing-7027/

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read the Flutter Style Guide recently, and have followed its advice.
  • I signed the CLA.
  • I listed at least one issue that this PR fixes in the description above.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or this PR is test-exempt.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@jmagman jmagman self-assigned this Jan 28, 2022
@jmagman
Copy link
Member Author

jmagman commented Jan 28, 2022

Context: want to test fix for regression at flutter/flutter#97356

Copy link
Contributor

@Hixie Hixie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jmagman
Copy link
Member Author

jmagman commented Jan 28, 2022

@jmagman
Copy link
Member Author

jmagman commented Jan 29, 2022

I can change it later if the rooster is too much. 🐓

@jmagman jmagman merged commit b5cf4ba into flutter:master Jan 29, 2022
@jmagman jmagman deleted the mp3 branch January 29, 2022 00:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants