[dashboard] Use flutter.js and local canvaskit. #2290
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change
This PR updates the dashboard's
web/index.html
to:flutter.js
to embed flutter (as described here).canvasKitBaseUrl
config option to load the locally distributed canvaskit, rather than the version from the external CDN.Note
Once this
flutter/engine
PR lands, the dashboard will start to warn (in development) aboutflutterConfiguration
being deprecated. The fix is to pass the configuration object to theinitializeEngine
call, like so (feel free to reach out to me for any assistance!):(This also updates the pubspec.lock with whatever was generated last in my machine)
Fixes
Pre-launch Checklist
///
).If you need help, consider asking for advice on the #hackers-new channel on Discord.