-
Notifications
You must be signed in to change notification settings - Fork 340
Fix issue where socket profile data was being displayed as web socket connections #8061
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Please add release notes for this change with a screenshot (preferably a smaller one than is in the PR description since this will be shown in DevTools release notes). Also, can you change the "Uri" column to "address" instead? I think that would better encompass both Socket traffic and Http traffic. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM once tests pass!
auto label is removed for flutter/devtools/8061, due to - The status or check suite devtools_app integration-test integration_dart2js - flutter - shard 3/3 has failed. Please fix the issues identified (or deflake) before re-applying this label. |
This comment was marked as abuse.
This comment was marked as abuse.
… connections (flutter#8061) * Fix issue where socket profile data was being displayed as web socket connections Fixes flutter#3033
Right now you'll need to be using the Flutter main branch on a commit that includes the updated Dart SDK. The changes might not have rolled all the way to Flutter yet, so your safest bet is to wait for the next beta release which includes these changes which will hopefully happen in the next week or two. |
* Fix overlapping UI on disconnect (#8057) * Fix issue where socket profile data was being displayed as web socket connections (#8061) * Fix issue where socket profile data was being displayed as web socket connections Fixes #3033 * Prepare cherry-pick release - DevTools 2.37.2 --------- Co-authored-by: Ben Konyi <[email protected]>
Socket data is now displayed correctly, with method set to
SOCKET
and type displaying the socket type (e.g.,TCP
vsUDP
).Fixes #3033