Disable iOS ScenariosTests suite

cbracken · cbracken · commit 36a8d5889dc0 · 2020-09-10T16:59:51.000-07:00
This leaves ScenariosUITests enabled. This also reverts commit 55d447a where one test was previously disabled. However, another started failing soon after, so instead we disable the whole suite here.
diff --git a/testing/scenario_app/ios/Scenarios/ScenariosTests/AppLifecycleTests.m b/testing/scenario_app/ios/Scenarios/ScenariosTests/AppLifecycleTests.m
@@ -227,9 +227,7 @@ - (void)testVisibleFlutterViewControllerRespondsToApplicationLifecycle {
   [engine setViewController:nil];
 }
 
-// TODO(cbracken): re-enable this test by removing the skip_ prefix once the source of its flakiness
-// has been identified. https://github.com/flutter/flutter/issues/61620
-- (void)skip_testFlutterViewControllerDetachingSendsApplicationLifecycle {
+- (void)testFlutterViewControllerDetachingSendsApplicationLifecycle {
   XCTestExpectation* engineStartedExpectation = [self expectationWithDescription:@"Engine started"];
 
   // Let the engine finish booting (at the end of which the channels are properly set-up) before

Original file line number	Diff line number	Diff line change
`@@ -227,9 +227,7 @@ - (void)testVisibleFlutterViewControllerRespondsToApplicationLifecycle {`
`227`	`227`	`[engine setViewController:nil];`
`228`	`228`	`}`
`229`	`229`
`230`		`-// TODO(cbracken): re-enable this test by removing the skip_ prefix once the source of its flakiness`
`231`		`-// has been identified. https://github.com/flutter/flutter/issues/61620`
`232`		`-- (void)skip_testFlutterViewControllerDetachingSendsApplicationLifecycle {`
	`230`	`+- (void)testFlutterViewControllerDetachingSendsApplicationLifecycle {`
`233`	`231`	`XCTestExpectation* engineStartedExpectation = [self expectationWithDescription:@"Engine started"];`
`234`	`232`
`235`	`233`	`// Let the engine finish booting (at the end of which the channels are properly set-up) before`