Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

Commit a04997c

Browse files
authored
[Impeller] Disable impeller_unittests. (#38307)
Fixes flutter/flutter#114872 Followup in flutter/flutter#117122
1 parent 3b2302c commit a04997c

File tree

1 file changed

+21
-19
lines changed

1 file changed

+21
-19
lines changed

testing/run_tests.py

+21-19
Original file line numberDiff line numberDiff line change
@@ -440,26 +440,28 @@ def make_test(name, flags=None, extra_env=None):
440440
shuffle_flags,
441441
coverage=coverage
442442
)
443+
# TODO(117122): Re-enable impeller_unittests after shader compiler errors
444+
# are addressed.
443445
# Impeller tests are only supported on macOS for now.
444-
run_engine_executable(
445-
build_dir,
446-
'impeller_unittests',
447-
executable_filter,
448-
shuffle_flags,
449-
coverage=coverage,
450-
extra_env={
451-
# pylint: disable=line-too-long
452-
# See https://developer.apple.com/documentation/metal/diagnosing_metal_programming_issues_early?language=objc
453-
'MTL_SHADER_VALIDATION':
454-
'1', # Enables all shader validation tests.
455-
'MTL_SHADER_VALIDATION_GLOBAL_MEMORY':
456-
'1', # Validates accesses to device and constant memory.
457-
'MTL_SHADER_VALIDATION_THREADGROUP_MEMORY':
458-
'1', # Validates accesses to threadgroup memory.
459-
'MTL_SHADER_VALIDATION_TEXTURE_USAGE':
460-
'1', # Validates that texture references are not nil.
461-
}
462-
)
446+
# run_engine_executable(
447+
# build_dir,
448+
# 'impeller_unittests',
449+
# executable_filter,
450+
# shuffle_flags,
451+
# coverage=coverage,
452+
# extra_env={
453+
# # pylint: disable=line-too-long
454+
# # See https://developer.apple.com/documentation/metal/diagnosing_metal_programming_issues_early?language=objc
455+
# 'MTL_SHADER_VALIDATION':
456+
# '1', # Enables all shader validation tests.
457+
# 'MTL_SHADER_VALIDATION_GLOBAL_MEMORY':
458+
# '1', # Validates accesses to device and constant memory.
459+
# 'MTL_SHADER_VALIDATION_THREADGROUP_MEMORY':
460+
# '1', # Validates accesses to threadgroup memory.
461+
# 'MTL_SHADER_VALIDATION_TEXTURE_USAGE':
462+
# '1', # Validates that texture references are not nil.
463+
# }
464+
# )
463465

464466

465467
def parse_impeller_vulkan_filter():

0 commit comments

Comments
 (0)