Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

Commit b37d328

Browse files
committed
Disable iOS ScenariosTests suite
This leaves ScenariosUITests enabled. This also reverts commit 55d447a where one test was previously disabled. However, another started failing soon after, so instead we disable the whole suite here.
1 parent 55d447a commit b37d328

File tree

2 files changed

+2
-4
lines changed

2 files changed

+2
-4
lines changed

testing/scenario_app/ios/Scenarios/Scenarios.xcodeproj/xcshareddata/xcschemes/Scenarios.xcscheme

+1-1
Original file line numberDiff line numberDiff line change
@@ -39,7 +39,7 @@
3939
</MacroExpansion>
4040
<Testables>
4141
<TestableReference
42-
skipped = "NO"
42+
skipped = "YES"
4343
testExecutionOrdering = "random">
4444
<BuildableReference
4545
BuildableIdentifier = "primary"

testing/scenario_app/ios/Scenarios/ScenariosTests/AppLifecycleTests.m

+1-3
Original file line numberDiff line numberDiff line change
@@ -227,9 +227,7 @@ - (void)testVisibleFlutterViewControllerRespondsToApplicationLifecycle {
227227
[engine setViewController:nil];
228228
}
229229

230-
// TODO(cbracken): re-enable this test by removing the skip_ prefix once the source of its flakiness
231-
// has been identified. https://github.com/flutter/flutter/issues/61620
232-
- (void)skip_testFlutterViewControllerDetachingSendsApplicationLifecycle {
230+
- (void)testFlutterViewControllerDetachingSendsApplicationLifecycle {
233231
XCTestExpectation* engineStartedExpectation = [self expectationWithDescription:@"Engine started"];
234232

235233
// Let the engine finish booting (at the end of which the channels are properly set-up) before

0 commit comments

Comments
 (0)