Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

Removes --causal-async-stacks from rule dart_snapshot_aot #19150

Closed
wants to merge 1 commit into from
Closed

Removes --causal-async-stacks from rule dart_snapshot_aot #19150

wants to merge 1 commit into from

Conversation

ghost
Copy link

@ghost ghost commented Jun 19, 2020

Description

The --causal-async-stacks flag is in the process of being phased out in favour of --lazy-async-stack which will become the new default.

Related Issues

dart-lang/sdk#39525

Checklist

Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes ([x]). This will ensure a smooth and quick review process.

  • I read the [contributor guide] and followed the process outlined there for submitting PRs.
  • I signed the [CLA].
  • I read and followed the [C++, Objective-C, Java style guides] for the engine.
  • I read the [tree hygiene] wiki page, which explains my responsibilities.
  • I updated/added relevant documentation.
  • All existing and new tests are passing.
  • I am willing to follow-up on review comments in a timely manner.

Breaking Change

Did any tests fail when you ran them? Please read [handling breaking changes].

  • No, no existing tests failed, so this is not a breaking change.

The --causal-async-stacks flag is in the process of being phased out in favour of --lazy-async-stack which will become the new default.
@ghost ghost closed this Jul 30, 2020
@ghost ghost deleted the master branch July 30, 2020 08:50
This pull request was closed.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants