Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

Re-enable (most) iOS Scenarios tests #21087

Merged
merged 1 commit into from
Sep 11, 2020
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -227,7 +227,9 @@ - (void)testVisibleFlutterViewControllerRespondsToApplicationLifecycle {
[engine setViewController:nil];
}

- (void)testFlutterViewControllerDetachingSendsApplicationLifecycle {
// TODO(cbracken): re-enable this test by removing the skip_ prefix once the source of its flakiness
// has been identified. https://github.com/flutter/flutter/issues/61620
- (void)skip_testFlutterViewControllerDetachingSendsApplicationLifecycle {
XCTestExpectation* engineStartedExpectation = [self expectationWithDescription:@"Engine started"];

// Let the engine finish booting (at the end of which the channels are properly set-up) before
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,9 @@ - (void)tearDown {
[super tearDown];
}

- (void)testSettingInitialRoute {
// TODO(cbracken): re-enable this test by removing the skip_ prefix once the source of its flakiness
// has been identified. https://github.com/flutter/flutter/issues/61620
- (void)skip_testSettingInitialRoute {
self.flutterViewController =
[[FlutterViewController alloc] initWithProject:nil
initialRoute:@"myCustomInitialRoute"
Expand Down
17 changes: 6 additions & 11 deletions testing/scenario_app/run_ios_tests.sh
Original file line number Diff line number Diff line change
Expand Up @@ -33,14 +33,9 @@ if [[ $# -eq 1 ]]; then
FLUTTER_ENGINE="$1"
fi

echo "iOS Scenarios tests currently disabled due to flakiness"
echo "See: https://github.com/flutter/flutter/issues/61620"

# TODO(cbracken): re-enable when
# https://github.com/flutter/flutter/issues/61620 is fixed.
# cd ios/Scenarios
# set -o pipefail && xcodebuild -sdk iphonesimulator \
# -scheme Scenarios \
# -destination 'platform=iOS Simulator,name=iPhone 8' \
# test \
# FLUTTER_ENGINE="$FLUTTER_ENGINE"
cd ios/Scenarios
set -o pipefail && xcodebuild -sdk iphonesimulator \
-scheme Scenarios \
-destination 'platform=iOS Simulator,name=iPhone 8' \
test \
FLUTTER_ENGINE="$FLUTTER_ENGINE"