Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

Fix erroneous dartdoc @tool directive. #21109

Merged
merged 1 commit into from
Sep 11, 2020

Conversation

srawlins
Copy link
Contributor

@srawlins srawlins commented Sep 11, 2020

Description

The snippets script, in the flutter dev/tools repo, with the sample command, needs a --template arg. The tool has been failing, and no samples are being generated.

Related Issues

Tests

I added the following tests:

none

Checklist

Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes ([x]). This will ensure a smooth and quick review process.

  • I read the contributor guide and followed the process outlined there for submitting PRs.
  • I signed the CLA.
  • I read and followed the C++, Objective-C, Java style guides for the engine.
  • I read the tree hygiene wiki page, which explains my responsibilities.
  • I updated/added relevant documentation.
  • All existing and new tests are passing.
  • I am willing to follow-up on review comments in a timely manner.

Breaking Change

Did any tests fail when you ran them? Please read handling breaking changes.

The snippets script, in the flutter dev/tools repo, with the sample command, needs a --template arg
@flutter-dashboard
Copy link

It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie on the #hackers channel in Chat.

Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing.

Copy link
Member

@goderbauer goderbauer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@goderbauer goderbauer added the waiting for tree to go green This PR is approved and tested, but waiting for the tree to be green to land. label Sep 11, 2020
@fluttergithubbot fluttergithubbot merged commit cda059e into flutter:master Sep 11, 2020
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Sep 11, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
cla: yes waiting for tree to go green This PR is approved and tested, but waiting for the tree to be green to land.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants